Skip to content

refactor: rename dropdown to picker #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2020
Merged

refactor: rename dropdown to picker #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4927023
feat: renamed dropdown to picker
GarthDB Jun 16, 2020
7841a4b
refactor!: renamed dropdown to picker
GarthDB Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 0 additions & 139 deletions components/dropdown/index.css
View file
Open in desktop

This file was deleted.

80 changes: 0 additions & 80 deletions components/dropdown/skin.css
View file
Open in desktop

This file was deleted.

24 changes: 12 additions & 12 deletions components/fieldlabel/metadata/form.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel spectrum-FieldLabel--left" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down Expand Up @@ -122,10 +122,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel spectrum-FieldLabel--right" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down Expand Up @@ -219,10 +219,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down
4 changes: 2 additions & 2 deletions components/fieldlabel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"devDependencies": {
"@spectrum-css/checkbox": "^3.0.0-beta.3",
"@spectrum-css/component-builder": "^1.2.0",
"@spectrum-css/dropdown": "^3.0.0-beta.3",
"@spectrum-css/picker": "^1.0.0",
"@spectrum-css/icon": "^2.1.1",
"@spectrum-css/radio": "^3.0.0-beta.2",
"@spectrum-css/stepper": "^3.0.0-beta.4",
Expand All @@ -34,4 +34,4 @@
"access": "public"
},
"homepage": "https://opensource.adobe.com/spectrum-css/"
}
}
0 components/dropdown/.npmignore → components/picker/.npmignore
View file
Open in desktop
File renamed without changes.
0 components/dropdown/CHANGELOG.md → components/picker/CHANGELOG.md
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions components/dropdown/README.md → components/picker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# @spectrum-css/dropdown
> The Spectrum CSS dropdown component
# @spectrum-css/picker

> The Spectrum CSS picker component

This package is part of the [Spectrum CSS project](https://github.com/adobe/spectrum-css).

Expand Down
0 components/dropdown/embed/Down-Chevron.svg → components/picker/embed/Down-Chevron.svg
View file
Open in desktop
File renamed without changes
0 components/dropdown/gulpfile.js → components/picker/gulpfile.js
View file
Open in desktop
File renamed without changes.
Loading