feat(storybook): live modifiers preview #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

castastrophe wants to merge 1 commit into main from castastrophe/feat-storybook-modifiers-docs

+2,232 −383

Collaborator

castastrophe commented Jul 11, 2025 •

edited

Loading

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

The documentation pages for at least two other components are still loading, including:

The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

VRTs have been run and looked at.
Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨

changeset-bot bot commented Jul 11, 2025 •

edited

Loading

🦋 Changeset detected

Latest commit: 5560468

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@spectrum-css/generator	Patch
@spectrum-css/preview	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR


          feat(storybook): custom properties panel

castastrophe force-pushed the castastrophe/feat-storybook-modifiers-docs branch from c7f092d to 5560468 Compare

July 11, 2025 19:42

github-actions bot reviewed

View reviewed changes

components/typography/stories/typography.stories.js

-              	DocsInternationalizedDetailVariants,
-              	DocsInternationalizedHeadingBodyPairing,
-              	DocsInternationalizedHeadingVariants, Template
+                  DocsBodyVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsBodyVariants,
          
            	DocsBodyVariants,

components/typography/stories/typography.stories.js

-              	DocsInternationalizedHeadingBodyPairing,
-              	DocsInternationalizedHeadingVariants, Template
+                  DocsBodyVariants,
+                  DocsCodeVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsCodeVariants,
          
            	DocsCodeVariants,

components/typography/stories/typography.stories.js

-              	DocsInternationalizedHeadingVariants, Template
+                  DocsBodyVariants,
+                  DocsCodeVariants,
+                  DocsDetailVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsDetailVariants,
          
            	DocsDetailVariants,

components/typography/stories/typography.stories.js

+                  DocsBodyVariants,
+                  DocsCodeVariants,
+                  DocsDetailVariants,
+                  DocsHeadingBodyPairing,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsHeadingBodyPairing,
          
            	DocsHeadingBodyPairing,

components/typography/stories/typography.stories.js

+                  DocsCodeVariants,
+                  DocsDetailVariants,
+                  DocsHeadingBodyPairing,
+                  DocsHeadingVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsHeadingVariants,
          
            	DocsHeadingVariants,

components/typography/stories/typography.stories.js

+                  DocsHeadingBodyPairing,
+                  DocsHeadingVariants,
+                  DocsInternationalizedBodyVariants,
+                  DocsInternationalizedCodeVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsInternationalizedCodeVariants,
          
            	DocsInternationalizedCodeVariants,

components/typography/stories/typography.stories.js

+                  DocsHeadingVariants,
+                  DocsInternationalizedBodyVariants,
+                  DocsInternationalizedCodeVariants,
+                  DocsInternationalizedDetailVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsInternationalizedDetailVariants,
          
            	DocsInternationalizedDetailVariants,

components/typography/stories/typography.stories.js

+                  DocsInternationalizedBodyVariants,
+                  DocsInternationalizedCodeVariants,
+                  DocsInternationalizedDetailVariants,
+                  DocsInternationalizedHeadingBodyPairing,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsInternationalizedHeadingBodyPairing,
          
            	DocsInternationalizedHeadingBodyPairing,

components/typography/stories/typography.stories.js

+                  DocsInternationalizedCodeVariants,
+                  DocsInternationalizedDetailVariants,
+                  DocsInternationalizedHeadingBodyPairing,
+                  DocsInternationalizedHeadingVariants,

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                DocsInternationalizedHeadingVariants,
          
            	DocsInternationalizedHeadingVariants,

components/typography/stories/typography.stories.js

+                  DocsInternationalizedDetailVariants,
+                  DocsInternationalizedHeadingBodyPairing,
+                  DocsInternationalizedHeadingVariants,
+                  Template

Contributor

github-actions bot Jul 11, 2025

⚠️ [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 1 tab but found 4 spaces.

Suggested change

      
                Template
          
            	Template

Contributor

github-actions bot commented Jul 11, 2025

File metrics

Summary

Total size: 2.25 MB^*

Package	Size	Minified	Gzipped
accordion	17.33 KB	16.56 KB	2.35 KB

accordion

Filename	Head	Minified	Gzipped	Compared to base
index-base.css	17.12 KB	16.35 KB	2.33 KB	🟢 ⬇ < 0.01 KB
index-theme.css	0.92 KB	0.90 KB	0.47 KB	-
index.css	17.33 KB	16.56 KB	2.35 KB	-
metadata.json	9.53 KB	-	-	-
themes/express.css	0.86 KB	0.85 KB	0.48 KB	-
themes/spectrum-two.css	0.86 KB	0.85 KB	0.48 KB	-
themes/spectrum.css	0.86 KB	0.85 KB	0.48 KB	-

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Contributor

github-actions bot commented Jul 11, 2025

🚀 Deployed on https://pr-4029--spectrum-css.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet