feat(accordion): add direct actions #4020
Draft
+239
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4480c6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 1.43 MB*
accordion
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
📚 Branch previewPR #4020 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4020/index.html. |
rise-erpelding
force-pushed
the
rise-erpelding/accordion-followups
branch
from
1f8e5b3 to
a2a2bc9
Compare
- updates test cases in order to use shorter content that fits better with the default width of accordion items
rise-erpelding
force-pushed
the
rise-erpelding/accordion-followups
branch
2 times, most recently
from
dc3ac58 to
812af2b
Compare
- adds direct actions feature to storybook, template, and css
rise-erpelding
force-pushed
the
rise-erpelding/accordion-followups
branch
from
812af2b to
ec8d50d
Compare
rise-erpelding
force-pushed
the
rise-erpelding/accordion-followups
branch
from
ec8d50d to
4480c6d
Compare
rise-erpelding
commented
Jul 11, 2025
Comment on lines
+77
to
+82
| /* Calculated vertical spacing for action button and switch to center them within the accordion item */ | ||
| --spectrum-accordion-item-direct-actions-vertical-spacing: calc( | ||
| (var(--mod-accordion-item-min-block-size, var(--spectrum-accordion-item-min-block-size)) - | ||
| var(--mod-accordion-item-direct-actions-height, var(--spectrum-accordion-item-direct-actions-height))) / 2 | ||
| ); | ||
|
|
There was a problem hiding this comment.
Did I miss a better way to do vertical spacing for this situation? I was finding that this got pretty complex, pretty fast:
- An
align-items: centeron the.spectrum-Accordion-itemDirectActionsisn't ideal when the text wraps because the designs show that we want direct actions to align with the first line of text, instead of all of them. - Accordion items have a min-height of
component-height-75/component-height-100/component-height-200/component-height-300, same with the direct actions, but we don't usually see that min-height in accordion (except for compact) because of the calculations for spacing and font-size * line-height making it larger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives the accordion component a minor update to include direct actions, which may consist of a quiet action button, switch, or both. Direct action items are vertically centered within the heading's first line of text for all sizes and densities, and maintain their own individual key focus states.
CSS-1204
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list