Skip to content

docs(menu): add migrated status badge #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: spectrum-two
Choose a base branch
from

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented May 15, 2025

Description

Adds the migrated status to the metadata for the menu component.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Verify the status: { type: "migrated" } object has been added to the menu's parameters. You should see the migrated badge when visiting the menu docs and story pages.
  • When building the branch locally, ensure no other metadata changes are generated. The metadata file changes in this PR look like they were probably just missed in a recent push to spectrum-two.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

@marissahuysentruyt marissahuysentruyt self-assigned this May 15, 2025
Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: 0fe7bf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marissahuysentruyt marissahuysentruyt added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 skip_vrt Add to a PR to skip running VRT (but still pass the action) labels May 15, 2025
Copy link
Contributor

github-actions bot commented May 15, 2025

🚀 Deployed on https://pr-3735--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented May 15, 2025

File metrics

Summary

Total size: 1.39 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review May 15, 2025 21:16
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/menu-add-migrated-tag-badge branch from a0868d5 to 0fe7bf9 Compare May 15, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant