Skip to content

feat(combobox): adding new s2 migration #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: spectrum-two
Choose a base branch
from

Conversation

aramos-adobe
Copy link
Contributor

@aramos-adobe aramos-adobe commented Apr 23, 2025

Combobox S2 Migration

The new combo box is coming in with more pronounced corner radius, thicker outline, and the use of the infield button nested inside. The quiet styling has also been deprecated.

New tokens

--spectrum-combobox-font-weight
--spectrum-combobox-line-height-cjk
--spectrum-combobox-spacing-alert-icon-to-text
--spectrum-combobox-spacing-to-help-text

New mods

--mod-combobox-line-height-cjk
--mod-combobox-popover-animation-distance
--mod-combobox-spacing-alert-icon-to-text
--mod-combobox-spacing-to-help-text
--mod-combobox-textfield-background-color

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Combobox matches the token spec
  • Layout
  • Icons
  • Embedded components
  • Colors
  • Typography

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

S1

Screenshot 2025-05-06 at 1 27 23 PM

S2

Screenshot 2025-05-06 at 1 26 55 PM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 055803f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/combobox Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aramos-adobe aramos-adobe self-assigned this Apr 23, 2025
@aramos-adobe aramos-adobe marked this pull request as draft April 23, 2025 16:30
@aramos-adobe aramos-adobe added the S2 Spectrum 2 label Apr 23, 2025
Base automatically changed from aramos-adobe/css770-infield-button-s2-migration to spectrum-two April 24, 2025 15:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

markdownlint-fix

[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-gray-50",
"--spectrum-gray-700",
"--spectrum-gray-800",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-negative-color-1100",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-neutral-background-color-selected-default",
"--spectrum-neutral-background-color-selected-down",
"--spectrum-neutral-background-color-selected-hover",
"--spectrum-neutral-background-color-selected-key-focus",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-text-to-control-100",


[markdownlint-fix] reported by reviewdog 🐶

"--highcontrast-checkbox-color-hover",


[markdownlint-fix] reported by reviewdog 🐶

"--highcontrast-checkbox-highlight-color-focus",

Copy link
Contributor

github-actions bot commented Apr 24, 2025

File metrics

Summary

Total size: 1.38 MB*
Total change (Δ): 🔴 ⬆ 0.16 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Minified Gzipped Δ
combobox 26.06 KB 25.04 KB 2.97 KB 🟢 ⬇ 2.01 KB
helptext 7.05 KB 6.75 KB 1.15 KB 🔴 ⬆ 0.12 KB

File change details

combobox

Filename Head Minified Gzipped Compared to base
index.css 26.06 KB 25.04 KB 2.97 KB 🟢 ⬇ 2.01 KB
metadata.json 15.67 KB - - 🟢 ⬇ 0.20 KB

helptext

Filename Head Minified Gzipped Compared to base
index.css 7.05 KB 6.75 KB 1.15 KB 🔴 ⬆ 0.12 KB
metadata.json 3.87 KB - - 🔴 ⬆ 0.10 KB

tokens

Filename Head Minified Gzipped Compared to base
css/dark-vars.css 46.64 KB - - -
css/global-vars.css 77.15 KB - - -
css/index.css 251.35 KB - - 🔴 ⬆ 0.08 KB
css/large-vars.css 41.29 KB - - 🔴 ⬆ 0.04 KB
css/light-vars.css 46.62 KB - - -
css/medium-vars.css 41.41 KB - - 🔴 ⬆ 0.04 KB
json/tokens.json 390.56 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Apr 24, 2025

🚀 Deployed on https://pr-3683--spectrum-css.netlify.app

@aramos-adobe aramos-adobe force-pushed the aramos-adobe/css769-combox-s2-migration branch from a986db0 to ff02395 Compare April 24, 2025 20:26
@castastrophe castastrophe force-pushed the spectrum-two branch 3 times, most recently from 7e8269c to 4ce8d19 Compare May 5, 2025 21:18
@aramos-adobe aramos-adobe marked this pull request as ready for review May 6, 2025 18:14
@aramos-adobe aramos-adobe added ready-for-review size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. run_vrt For use on PRs looking to kick off VRT labels May 6, 2025
@aramos-adobe aramos-adobe added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant