-
Notifications
You must be signed in to change notification settings - Fork 201
feat(combobox): adding new s2 migration #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectrum-two
Are you sure you want to change the base?
feat(combobox): adding new s2 migration #3683
Conversation
🦋 Changeset detectedLatest commit: 055803f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
markdownlint-fix
[markdownlint-fix] reported by reviewdog 🐶
spectrum-css/components/checkbox/dist/metadata.json
Lines 195 to 197 in a986db0
"--spectrum-gray-50", | |
"--spectrum-gray-700", | |
"--spectrum-gray-800", |
[markdownlint-fix] reported by reviewdog 🐶
"--spectrum-negative-color-1100", |
[markdownlint-fix] reported by reviewdog 🐶
spectrum-css/components/checkbox/dist/metadata.json
Lines 202 to 205 in a986db0
"--spectrum-neutral-background-color-selected-default", | |
"--spectrum-neutral-background-color-selected-down", | |
"--spectrum-neutral-background-color-selected-hover", | |
"--spectrum-neutral-background-color-selected-key-focus", |
[markdownlint-fix] reported by reviewdog 🐶
"--spectrum-text-to-control-100", |
[markdownlint-fix] reported by reviewdog 🐶
"--highcontrast-checkbox-color-hover", |
[markdownlint-fix] reported by reviewdog 🐶
"--highcontrast-checkbox-highlight-color-focus", |
File metricsSummaryTotal size: 1.38 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
File change detailscombobox
helptext
tokens
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-3683--spectrum-css.netlify.app |
a986db0
to
ff02395
Compare
7e8269c
to
4ce8d19
Compare
Combobox S2 Migration
The new combo box is coming in with more pronounced corner radius, thicker outline, and the use of the infield button nested inside. The quiet styling has also been deprecated.
New tokens
--spectrum-combobox-font-weight
--spectrum-combobox-line-height-cjk
--spectrum-combobox-spacing-alert-icon-to-text
--spectrum-combobox-spacing-to-help-text
New mods
--mod-combobox-line-height-cjk
--mod-combobox-popover-animation-distance
--mod-combobox-spacing-alert-icon-to-text
--mod-combobox-spacing-to-help-text
--mod-combobox-textfield-background-color
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
S1
S2
To-do list