Skip to content

fix(picker): update S2 border-color [SWC-641] #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 4, 2025
Merged

fix(picker): update S2 border-color [SWC-641] #3584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
426e5f1
chore: upgrade picker
blunteshwar Feb 27, 2025
c96b226
chore: added changeset
blunteshwar Feb 27, 2025
872691b
chore(picker): minor fix
blunteshwar Feb 27, 2025
e312faf
chore: updated changeset
blunteshwar Feb 28, 2025
0d1ddf5
chore: minor fix
blunteshwar Feb 28, 2025
d271bc9
minor fix
blunteshwar Feb 28, 2025
8a255de
chore: updated changeset
blunteshwar Feb 28, 2025
aa6b374
chore: updated changeset description
blunteshwar Feb 28, 2025
52a5916
chore: format the changeset
castastrophe Feb 28, 2025
7f4d9f8
fix(picker): open not hover background and border color fix for s2
Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-houses-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/picker": patch
---

Previously, the --spectrum-picker-border-color-default-open was gray-500, but the spec shows it as gray-800. This change aligns the component with the spec by updating the --spectrum-picker-border-color-default-open to gray-800.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajdeepc Should we add a quick note here about the background color update for the s2 theme?

4 changes: 2 additions & 2 deletions components/picker/themes/spectrum-two.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
@container style(--system: spectrum) {
.spectrum-Picker {
--spectrum-picker-background-color-default: var(--spectrum-gray-100);
--spectrum-picker-background-color-default-open: var(--spectrum-gray-100);
--spectrum-picker-background-color-default-open: var(--spectrum-gray-200);
--spectrum-picker-background-color-hover: var(--spectrum-gray-200);
--spectrum-picker-background-color-hover-open: var(--spectrum-gray-200);
--spectrum-picker-background-color-active: var(--spectrum-gray-200);
--spectrum-picker-background-color-key-focus: var(--spectrum-gray-200);

--spectrum-picker-border-color-default: var(--spectrum-gray-500);
--spectrum-picker-border-color-default-open: var(--spectrum-gray-500);
--spectrum-picker-border-color-default-open: var(--spectrum-neutral-content-color-focus);
--spectrum-picker-border-color-hover: var(--spectrum-gray-600);
--spectrum-picker-border-color-hover-open: var(--spectrum-gray-900);
--spectrum-picker-border-color-active: var(--spectrum-gray-700);
Expand Down
1 change: 1 addition & 0 deletions components/picker/themes/spectrum.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
--spectrum-picker-background-color-key-focus: var(--spectrum-gray-200);

--spectrum-picker-border-color-default: var(--spectrum-gray-500);
--spectrum-picker-border-color-default-open: var(--spectrum-gray-500);
--spectrum-picker-border-color-hover-open: var(--spectrum-gray-600);
--spectrum-picker-border-color-key-focus: var(--spectrum-gray-600);
--spectrum-picker-border-color-disabled: transparent;
Expand Down
Loading