Skip to content

feat(contextualhelp): add mod to allow max-width #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Jan 28, 2025

Description

Added a --mod property to allow consumers to set a max-width on the contextual help component.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: b7e1c04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/contextualhelp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2025

🚀 Deployed on https://pr-3523--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Jan 28, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
contextualhelp 2.20 KB 2.11 KB 0.73 KB

contextualhelp

Filename Head Minified Gzipped Compared to base
index.css 2.20 KB 2.11 KB 0.73 KB 🔴 ⬆ 0.08 KB
metadata.json 1.30 KB - - 🔴 ⬆ 0.06 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@TarunAdobe TarunAdobe marked this pull request as ready for review January 28, 2025 11:41
@TarunAdobe TarunAdobe requested review from mdt2 and castastrophe and removed request for mdt2 January 28, 2025 11:41
@TarunAdobe TarunAdobe self-assigned this Jan 28, 2025
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TarunAdobe Nice work on this! I requested a few minor changes, but overall this is looking really good.

How would you feel about adding some documentation for these new stories? Even something pretty simple, like what you have in the changeset, would be nice.

Example docs: (feel free to expand on this- you can probably do a better job than me!)
"In order to further customize the contextual help popover, implementations can set --mod-spectrum-contextual-help-popover-maximum-width to their desired max width."

It might give users a little head start of figuring out how to customize this component.

@marissahuysentruyt
Copy link
Collaborator

@castastrophe @TarunAdobe oh I was just thinking- do we need to run VRTs on this branch before it merges? Since we updated the body content of the stories, I think Chromatic would flag it, right?

@castastrophe castastrophe changed the title chore(contextual-help): add mod to allow max-width feat(contextualhelp): add mod to allow max-width Feb 13, 2025
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review labels Feb 13, 2025
@castastrophe castastrophe enabled auto-merge (squash) February 13, 2025 19:13
@marissahuysentruyt marissahuysentruyt dismissed their stale review February 13, 2025 19:17

Don't want to hold up merging this! Quickly glancing, it's looking good!

@castastrophe castastrophe merged commit 71f7d4f into main Feb 13, 2025
13 of 21 checks passed
@castastrophe castastrophe deleted the ttomar/swc-509 branch February 13, 2025 19:19
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants