-
Notifications
You must be signed in to change notification settings - Fork 202
feat(contextualhelp): add mod to allow max-width #3523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b7e1c04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3523--spectrum-css.netlify.app |
File metricsSummaryTotal size: 2.25 MB*
contextualhelp
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
a5ef3a6
to
db15e38
Compare
db15e38
to
a83b27f
Compare
a83b27f
to
70cf597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TarunAdobe Nice work on this! I requested a few minor changes, but overall this is looking really good.
How would you feel about adding some documentation for these new stories? Even something pretty simple, like what you have in the changeset, would be nice.
Example docs: (feel free to expand on this- you can probably do a better job than me!)
"In order to further customize the contextual help popover, implementations can set --mod-spectrum-contextual-help-popover-maximum-width
to their desired max width."
It might give users a little head start of figuring out how to customize this component.
@castastrophe @TarunAdobe oh I was just thinking- do we need to run VRTs on this branch before it merges? Since we updated the body content of the stories, I think Chromatic would flag it, right? |
Don't want to hold up merging this! Quickly glancing, it's looking good!
Description
Added a
--mod
property to allow consumers to set amax-width
on the contextual help component.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list