fix: restore undefined custom properties [part 5] #3475

5t3ph · 2025-01-03T17:59:31Z

Description

Restore missing custom properties from the foundations spectrum two theme files that were flagged by the linter. This fixes linter errors for the following components:

Sidenav
Rating
Slider
Switch
Datepicker

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

@jawinn :

yarn linter sidenav no longer shows errors or warnings
yarn linter rating no longer shows errors or warnings
yarn linter slider no longer shows errors or warnings
yarn linter switch no longer shows errors or warnings
yarn linter datepicker no longer shows errors or warnings

To-do list

✨ This pull request is ready to merge. ✨

Bumps [diff2html](https://github.com/rtfpessoa/diff2html) from 3.4.48 to 3.4.51. - [Release notes](https://github.com/rtfpessoa/diff2html/releases) - [Commits](rtfpessoa/diff2html@3.4.48...3.4.51) --- updated-dependencies: - dependency-name: diff2html dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump lint-staged from 15.2.11 to 15.3.0 Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.11 to 15.3.0. - [Release notes](https://github.com/lint-staged/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v15.2.11...v15.3.0) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build: update config tooling to resolve lint-staged correctly --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>

changeset-bot · 2025-01-03T17:59:35Z

🦋 Changeset detected

Latest commit: a8ffabc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@spectrum-css/datepicker	Patch
@spectrum-css/rating	Patch
@spectrum-css/sidenav	Patch
@spectrum-css/slider	Patch
@spectrum-css/switch	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-03T18:02:53Z

🚀 Deployed on https://pr-3475--spectrum-css.netlify.app

github-actions · 2025-01-03T18:05:28Z

File metrics

Summary

Total size: 1.73 MB^*
Total change (Δ): 🔴 ⬆ 2.30 KB (0.13%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
datepicker	12.94 KB	🔴 ⬆ 0.08 KB
rating	8.57 KB	🔴 ⬆ 0.42 KB
sidenav	14.46 KB	🔴 ⬆ 0.51 KB
slider	29.38 KB	🔴 ⬆ 1.38 KB
switch	24.46 KB	🟢 ⬇ 0.06 KB

Details

datepicker

Filename	Head	Compared to base
index.css	12.94 KB	🔴 ⬆ 0.08 KB (0.58%)

rating

Filename	Head	Compared to base
index.css	8.57 KB	🔴 ⬆ 0.42 KB (5.01%)

sidenav

Filename	Head	Compared to base
index.css	14.46 KB	🔴 ⬆ 0.51 KB (3.55%)

slider

Filename	Head	Compared to base
index.css	29.38 KB	🔴 ⬆ 1.38 KB (4.95%)

switch

Filename	Head	Compared to base
index.css	24.46 KB	🟢 ⬇ 0.06 KB (-0.25%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/tschaub/gh-pages/releases) - [Changelog](https://github.com/tschaub/gh-pages/blob/main/changelog.md) - [Commits](tschaub/gh-pages@v6.2.0...v6.3.0) --- updated-dependencies: - dependency-name: gh-pages dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

rise-erpelding

Looks great!

Noting that Datepicker still looks a little off, but it appears to be because of other components that weren't fixed in this PR such as popover, textfield, and action button.

Bumps [chromatic](https://github.com/chromaui/chromatic-cli) from 11.20.2 to 11.22.0. - [Release notes](https://github.com/chromaui/chromatic-cli/releases) - [Changelog](https://github.com/chromaui/chromatic-cli/blob/main/CHANGELOG.md) - [Commits](chromaui/chromatic-cli@v11.20.2...v11.22.0) --- updated-dependencies: - dependency-name: chromatic dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…kles/css-1087-undef-props-part-5

…com/adobe/spectrum-css into seckles/css-1087-undef-props-part-5

…into seckles/css-1087-undef-props-part-5

dependabot bot and others added 5 commits January 2, 2025 10:57

chore(caniuse-lite): dependency update (#3467)

b679cb3

fix(*): restore missing custom properties

bda6e74

fix(sidenav): restore missing custom properties

21477d5

5t3ph added the S2 Spectrum 2 label Jan 3, 2025

Add changeset

a4c933e

5t3ph added the ready-for-review label Jan 3, 2025

jawinn self-requested a review January 3, 2025 19:03

jawinn approved these changes Jan 3, 2025

View reviewed changes

rise-erpelding self-requested a review January 6, 2025 14:34

rise-erpelding approved these changes Jan 6, 2025

View reviewed changes

dependabot bot and others added 6 commits January 6, 2025 09:40

Merge branch 'main' of https://github.com/adobe/spectrum-css into sec…

5c99c92

…kles/css-1087-undef-props-part-5

Merge branch 'main' of https://github.com/adobe/spectrum-css into sec…

f9defa3

…kles/css-1087-undef-props-part-5

Merge branch 'seckles/css-1087-undef-props-part-5' of https://github.…

e792219

…com/adobe/spectrum-css into seckles/css-1087-undef-props-part-5

Revert incorrect main merge

ea56978

Merge branch 'spectrum-two' of https://github.com/adobe/spectrum-css …

a8ffabc

…into seckles/css-1087-undef-props-part-5

5t3ph merged commit 52e773e into spectrum-two Jan 6, 2025
12 checks passed

5t3ph deleted the seckles/css-1087-undef-props-part-5 branch January 6, 2025 15:35

castastrophe pushed a commit that referenced this pull request Jan 17, 2025

fix: restore undefined custom properties [part 5] (#3475)

16b3b62

castastrophe pushed a commit that referenced this pull request Jan 17, 2025

fix: restore undefined custom properties [part 5] (#3475)

807b3fb

castastrophe pushed a commit that referenced this pull request Jan 21, 2025

fix: restore undefined custom properties [part 5] (#3475)

5fae8ab

castastrophe pushed a commit that referenced this pull request Jan 22, 2025

fix: restore undefined custom properties [part 5] (#3475)

7bd2503

castastrophe pushed a commit that referenced this pull request Feb 5, 2025

fix: restore undefined custom properties [part 5] (#3475)

945648e

castastrophe pushed a commit that referenced this pull request Feb 7, 2025

fix: restore undefined custom properties [part 5] (#3475)

ae8ac9f

castastrophe pushed a commit that referenced this pull request Feb 7, 2025

fix: restore undefined custom properties [part 5] (#3475)

93303b3

castastrophe pushed a commit that referenced this pull request Feb 7, 2025

fix: restore undefined custom properties [part 5] (#3475)

fe88573

castastrophe pushed a commit that referenced this pull request Feb 11, 2025

fix: restore undefined custom properties [part 5] (#3475)

f005691

castastrophe pushed a commit that referenced this pull request Feb 24, 2025

fix: restore undefined custom properties [part 5] (#3475)

5844b71

castastrophe pushed a commit that referenced this pull request Feb 24, 2025

fix: restore undefined custom properties [part 5] (#3475)

80496fd

castastrophe pushed a commit that referenced this pull request Feb 25, 2025

fix: restore undefined custom properties [part 5] (#3475)

ae95f0e

castastrophe mentioned this pull request Apr 15, 2025

feat(tokens,card): update to @adobe/spectrum-tokens@13.3.0 #3669

Merged

12 tasks

This was referenced May 16, 2025

chore(swatch,menu,swatchgroup): fix reverted metadata assets #3752

Merged

chore: merge latest updates from main #3777

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: restore undefined custom properties [part 5] #3475

fix: restore undefined custom properties [part 5] #3475

Uh oh!

5t3ph commented Jan 3, 2025 •

edited by jawinn

Loading

Uh oh!

changeset-bot bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 3, 2025 •

edited

Loading

datepicker

rating

sidenav

slider

switch

Uh oh!

rise-erpelding left a comment

Uh oh!

Uh oh!

Uh oh!

fix: restore undefined custom properties [part 5] #3475

fix: restore undefined custom properties [part 5] #3475

Uh oh!

Conversation

5t3ph commented Jan 3, 2025 • edited by jawinn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How and where has this been tested?

Validation steps

To-do list

Uh oh!

changeset-bot bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File metrics

Summary

datepicker

rating

sidenav

slider

switch

Uh oh!

rise-erpelding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

5t3ph commented Jan 3, 2025 •

edited by jawinn

Loading

changeset-bot bot commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading