fix: restore undefined custom properties [part 4]

[jawinn]

Description

Restore missing custom properties from the foundations spectrum two theme files that were flagged by the linter. This fixes linter errors for the following components: search, combobox, colorwheel, assetcard, and treeview.

CSS-1086

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Checked by @5t3ph

• yarn linter search no longer shows errors or warnings
• yarn linter combobox no longer shows errors or warnings
• yarn linter colorwheel no longer shows errors or warnings
• yarn linter assetcard no longer shows errors or warnings
• yarn linter treeview no longer shows errors or warnings

To-do list

• I have read the contribution guidelines.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: d8f691d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@spectrum-css/colorwheel	Patch
@spectrum-css/assetcard	Patch
@spectrum-css/combobox	Patch
@spectrum-css/treeview	Patch
@spectrum-css/search	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Deployed on https://pr-3473--spectrum-css.netlify.app

[github-actions]

File metrics

Summary

Total size: 1.73 MB^*
Total change (Δ): 🔴 ⬆ 1.84 KB (0.10%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
assetcard	16.14 KB	🔴 ⬆ 0.50 KB
colorwheel	4.39 KB	🔴 ⬆ 0.08 KB
combobox	28.64 KB	🔴 ⬆ 0.42 KB
search	11.37 KB	🔴 ⬆ 0.73 KB
treeview	17.71 KB	🔴 ⬆ 0.15 KB

Details

assetcard

Filename	Head	Compared to base
index.css	16.14 KB	🔴 ⬆ 0.50 KB (3.13%)

colorwheel

Filename	Head	Compared to base
index.css	4.39 KB	🔴 ⬆ 0.08 KB (1.72%)

combobox

Filename	Head	Compared to base
index.css	28.64 KB	🔴 ⬆ 0.42 KB (1.46%)

search

Filename	Head	Compared to base
index.css	11.37 KB	🔴 ⬆ 0.73 KB (6.69%)

treeview

Filename	Head	Compared to base
index.css	17.71 KB	🔴 ⬆ 0.15 KB (0.85%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[5t3ph]

All clear!

[marissahuysentruyt]

Things are looking good, except for combobox I believe. I don't get any errors, but I did get a few warnings about undefined --highcontrast-* variables:

Looks like they're actually related to the textfield that combobox uses. It looks like they're defined in main: https://github.com/adobe/spectrum-css/blob/main/components/textfield/index.css#L668 and in s2-foundations-redux: https://github.com/adobe/spectrum-css/blame/s2-foundations-redux/components/textfield/index.css#L648

If they're textfield custom properties, that might be taken care of in another PR, so maybe this comment can be disregarded!

[marissahuysentruyt]

After some troubleshooting, this is looking great! Thanks for your help and the reminder for yarn clean 👍