Skip to content

chore(coachindicator): correct the title of coachindicator #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented Dec 6, 2024

Description

This PR removes the "components/" from the title key of the coach indicator. This was causing the side nav to render a components folder, where coachIndicator was nested, instead of simply rendering the Coach indicator link.

Before 🚫
Screenshot 2024-12-05 at 8 37 05 PM

After ✅
Screenshot 2024-12-05 at 8 37 34 PM

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the branch or use the deploy preview
  • On the homepage, verify that Coach indicator appears in the side navigation, instead of components/ (see the screenshots above.
  • Verify the coach indicator link in the side nav does, in fact, take you to the coach indicator docs page as expected.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes. (no changes to components have been introduced)

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

removes the "components/" prefix from the `title` key in the default
coachindicator
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: d55ae56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@spectrum-css/avatar Major
@spectrum-css/thumbnail Major
@spectrum-css/colorarea Major
@spectrum-css/colorloupe Major
@spectrum-css/opacitycheckerboard Major
@spectrum-css/tag Major
@spectrum-css/table Major
@spectrum-css/treeview Major
@spectrum-css/colorwheel Major
@spectrum-css/colorhandle Major
@spectrum-css/colorslider Major
@spectrum-css/swatch Major
@spectrum-css/taggroup Major
@spectrum-css/preview Patch
@spectrum-css/swatchgroup Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marissahuysentruyt marissahuysentruyt changed the base branch from main to spectrum-two December 6, 2024 01:46
@marissahuysentruyt marissahuysentruyt added S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. storybook labels Dec 6, 2024
@marissahuysentruyt marissahuysentruyt self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

🚀 Deployed on https://pr-3431--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Dec 6, 2024

File metrics

Summary

Total size: 2.74 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review December 6, 2024 03:09
@marissahuysentruyt marissahuysentruyt merged commit 838532e into spectrum-two Dec 6, 2024
29 of 44 checks passed
@marissahuysentruyt marissahuysentruyt deleted the marissahuysentruyt/remove-components-prefix-coachindicator branch December 6, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants