Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stylelint): addresses remaining stylelint violations #3359

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 31, 2024

Description

For CSS-1040.

This resolves our remaining stylelint issues around undefined tokens, rule order, unused values and color syntax.

  • Updates invalid color syntax from rgba(N, N, N, N) to rgba(N N N / N).
  • In cases of duplicate properties, preserves the property that would be applied given current code structure.
  • Updates misnamed tokens to use valid tokens (table/index.css).

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch from f5dcf7d to d8a8595 Compare October 31, 2024 21:06
Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 078ba81

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2024

🚀 Deployed on https://pr-3359--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 31, 2024

File metrics

Summary

Total size: 3.89 MB*
Total change (Δ): 🟢 ⬇ 1.56 KB (-0.04%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
calendar 19.14 KB 🟢 ⬇ 0.14 KB
card 20.24 KB 🟢 ⬇ 0.04 KB
infieldbutton 18.14 KB 🟢 ⬇ 0.01 KB
modal 5.38 KB 🟢 ⬇ 0.06 KB
radio 17.58 KB 🔴 ⬆ < 0.01 KB
stepper 20.57 KB 🟢 ⬇ 0.10 KB
table 46.84 KB 🟢 ⬇ 0.14 KB
underlay 3.17 KB 🟢 ⬇ 0.10 KB

Details

calendar

Filename Head Compared to base
index-base.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)
index-vars.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)
index.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)

card

Filename Head Compared to base
index-base.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)
index-vars.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)
index.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)

infieldbutton

Filename Head Compared to base
index-base.css 16.00 KB 🟢 ⬇ 0.01 KB (-0.04%)
index-theme.css 2.75 KB -
index-vars.css 18.14 KB 🟢 ⬇ 0.01 KB (-0.04%)
index.css 18.14 KB 🟢 ⬇ 0.01 KB (-0.04%)
themes/express.css 1.67 KB -
themes/spectrum.css 1.69 KB -

modal

Filename Head Compared to base
index-base.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)
index-vars.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)
index.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)

radio

Filename Head Compared to base
index-base.css 16.52 KB 🔴 ⬆ < 0.01 KB (0.02%)
index-theme.css 1.67 KB -
index-vars.css 17.58 KB 🔴 ⬆ < 0.01 KB (0.02%)
index.css 17.58 KB 🔴 ⬆ < 0.01 KB (0.02%)
themes/express.css 1.35 KB -
themes/spectrum.css 1.35 KB -

stepper

Filename Head Compared to base
index-base.css 17.03 KB 🟢 ⬇ 0.25 KB (-1.42%)
index-theme.css 4.15 KB 🔴 ⬆ 0.15 KB (3.61%)
index-vars.css 20.57 KB 🟢 ⬇ 0.10 KB (-0.49%)
index.css 20.57 KB 🟢 ⬇ 0.10 KB (-0.49%)
themes/express.css 2.33 KB -
themes/spectrum.css 2.43 KB 🔴 ⬆ 0.15 KB (6.32%)

table

Filename Head Compared to base
index-base.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)
index-vars.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)
index.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)

underlay

Filename Head Compared to base
index-base.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)
index-vars.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)
index.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf self-assigned this Oct 31, 2024
@cdransf cdransf added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. ready-for-review run_vrt For use on PRs looking to kick off VRT labels Oct 31, 2024
@cdransf cdransf marked this pull request as ready for review October 31, 2024 21:49
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch from d8a8595 to 8c0142b Compare October 31, 2024 21:50
@cdransf cdransf marked this pull request as draft October 31, 2024 21:57
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch from 8c0142b to e1b8501 Compare October 31, 2024 22:02
@cdransf cdransf marked this pull request as ready for review October 31, 2024 22:07
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch 5 times, most recently from 8812a1a to 1a1fbdf Compare November 5, 2024 17:45
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch 6 times, most recently from a4f597e to d0d71e2 Compare November 12, 2024 21:04
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch from d0d71e2 to 74a8314 Compare November 12, 2024 23:37
@cdransf cdransf added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Dec 10, 2024
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch from bcfc954 to 61a58bf Compare December 17, 2024 18:38
@castastrophe castastrophe force-pushed the cdransf/stylelint-cleanup branch 4 times, most recently from 3e294d8 to 21aa291 Compare January 22, 2025 14:26
@castastrophe castastrophe changed the title chore(stylelint): addresses remaining stylelint violations fix(stylelint): addresses remaining stylelint violations Jan 22, 2025
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed blocked See description and comments for what is blocking this issue skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Jan 22, 2025
@castastrophe castastrophe force-pushed the cdransf/stylelint-cleanup branch 3 times, most recently from 7666485 to 7fe4936 Compare January 22, 2025 14:32
@adobe adobe deleted a comment from github-actions bot Jan 22, 2025
@adobe adobe deleted a comment from github-actions bot Jan 22, 2025
@castastrophe castastrophe force-pushed the cdransf/stylelint-cleanup branch from 7fe4936 to f4ee597 Compare January 22, 2025 14:36
@@ -279,7 +277,7 @@
transition: border-color var(--mod-stepper-animation-duration, var(--spectrum-stepper-animation-duration)) ease-in-out;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [stylelint] <plugin/no-low-performance-animation-properties> reported by reviewdog 🐶
Unexpected use of low performance transition property (border-color).

@castastrophe castastrophe force-pushed the cdransf/stylelint-cleanup branch 6 times, most recently from 9c872ca to 58fb20c Compare January 22, 2025 15:26
@castastrophe castastrophe force-pushed the cdransf/stylelint-cleanup branch from 58fb20c to 078ba81 Compare January 22, 2025 15:32
@castastrophe castastrophe merged commit c8194b0 into main Jan 22, 2025
13 of 14 checks passed
@castastrophe castastrophe deleted the cdransf/stylelint-cleanup branch January 22, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-3 M ~18-30hrs; moderate effort or complexity, several work days needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants