chore(stylelint): audit and remove unnecessary stylelint properties #3346

cdransf · 2024-10-29T13:54:54Z

Description

Adjusts nesting violation in checkbox and removes stylelint disable comments.
Removes unnecessary disable from colorhandle, colorloupe, site and swatch.
Updates stylelint config to ignore forced-color-adjust: preserve-parent-color
Adjusts property order and nesting in switch to resolve stylelint violations

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Fetch the branch
Run yarn linter and verify that there are no max depth, property order, unknown custom property, max precision, declaration property no unknown or forced color violations

Regression testing

Validate:

The documentation pages for at least two other components are still loading, including:

The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

VRTs have been run and looked at.
Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨

changeset-bot · 2024-10-29T13:54:58Z

⚠️ No Changeset found

Latest commit: 8765292

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-10-29T17:13:46Z

🚀 Deployed on https://pr-3346--spectrum-css.netlify.app

github-actions · 2024-10-29T17:14:24Z

File metrics

Summary

Total size: 4.30 MB^*
Total change (Δ): 🟢 ⬇ 0.56 KB (-0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
checkbox	24.20 KB	🟢 ⬇ 0.01 KB
dial	11.25 KB	🟢 ⬇ 0.01 KB
slider	32.24 KB	🟢 ⬇ 0.17 KB

Details

checkbox

Filename	Head	Compared to base
index-base.css	23.58 KB	🟢 ⬇ 0.01 KB (-0.05%)
index-theme.css	1.24 KB	-
index-vars.css	24.20 KB	🟢 ⬇ 0.01 KB (-0.05%)
index.css	24.20 KB	🟢 ⬇ 0.01 KB (-0.05%)
themes/express.css	0.95 KB	-
themes/spectrum.css	0.94 KB	-

dial

Filename	Head	Compared to base
index-base.css	11.25 KB	🟢 ⬇ 0.01 KB (-0.06%)
index-vars.css	11.25 KB	🟢 ⬇ 0.01 KB (-0.06%)
index.css	11.25 KB	🟢 ⬇ 0.01 KB (-0.06%)

slider

Filename	Head	Compared to base
index-base.css	29.93 KB	🟢 ⬇ 0.17 KB (-0.55%)
index-theme.css	2.92 KB	-
index-vars.css	32.24 KB	🟢 ⬇ 0.17 KB (-0.51%)
index.css	32.24 KB	🟢 ⬇ 0.17 KB (-0.51%)
themes/express.css	1.78 KB	-
themes/spectrum.css	1.75 KB	-

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

castastrophe

Approved however some of the switch updates might be challenging to merge in with the foundations work. I think it should be fine though. I'll take the rebase carefully.

components/checkbox/index.css

stylelint.config.js

marissahuysentruyt

I sent you a Slack as well, but when I run yarn linter I see 2 errors in my terminal for switch and swatch regarding max-nesting-depth.

components/checkbox/index.css

components/switch/index.css

marissahuysentruyt

Looks great! I don't think I see any of the errors you mentioned in the PR description 🏆

This may be in other work or cards, maybe we don't want addressing them, but I wanted to just list a few of the other stylelint errors I see in my terminal:

plugin/no-low-performance-animation-properties (various components)
selector-class-pattern (i.e. typography, stepper)
spectrum-tool/no-unknown-custom-properties (i.e. infield button, radio)
spectrum-tools/no-unused-custom-properties (i.e. slider, table)
order/order (i.e. tooltip)

- Removes unnecessary disables - Adjusts nesting to resolve lint violations - update opacity values and remove comments for unsupported ChromeVox version

cdransf added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 29, 2024

cdransf requested review from jawinn, castastrophe and 5t3ph October 29, 2024 13:54

cdransf self-assigned this Oct 29, 2024

cdransf force-pushed the cdransf/stylelint-disable-audit branch from c96a038 to 2b2ed76 Compare October 29, 2024 17:09

cdransf added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 29, 2024

castastrophe approved these changes Oct 30, 2024

View reviewed changes

components/checkbox/index.css Outdated Show resolved Hide resolved

stylelint.config.js Show resolved Hide resolved

marissahuysentruyt reviewed Oct 30, 2024

View reviewed changes

components/checkbox/index.css Show resolved Hide resolved

components/switch/index.css Outdated Show resolved Hide resolved

cdransf force-pushed the cdransf/stylelint-disable-audit branch 2 times, most recently from 4196d36 to 0de5503 Compare October 30, 2024 15:53

cdransf added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Oct 30, 2024

cdransf requested a review from marissahuysentruyt October 30, 2024 15:58

marissahuysentruyt approved these changes Oct 30, 2024

View reviewed changes

cdransf force-pushed the cdransf/stylelint-disable-audit branch from 0de5503 to e1843d8 Compare October 30, 2024 16:30

cdransf added 4 commits October 30, 2024 09:30

chore(stylelint): remove unnecessary disable comments

7eebaf7

chore(colorhandle): removes unnecessary disable

8666a70

chore(stylelint): adds supported forced color value to ignoreProperties

86f8e59

- Removes unnecessary disables - Adjusts nesting to resolve lint violations - update opacity values and remove comments for unsupported ChromeVox version

chore(stylelint): fix max nesting violations

8765292

cdransf force-pushed the cdransf/stylelint-disable-audit branch from e1843d8 to 8765292 Compare October 30, 2024 16:30

cdransf merged commit 469f731 into main Oct 30, 2024
12 checks passed

cdransf deleted the cdransf/stylelint-disable-audit branch October 30, 2024 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(stylelint): audit and remove unnecessary stylelint properties #3346

chore(stylelint): audit and remove unnecessary stylelint properties #3346

cdransf commented Oct 29, 2024 •

edited

Loading

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

checkbox

dial

slider

castastrophe left a comment

marissahuysentruyt left a comment

marissahuysentruyt left a comment

chore(stylelint): audit and remove unnecessary stylelint properties #3346

chore(stylelint): audit and remove unnecessary stylelint properties #3346

Conversation

cdransf commented Oct 29, 2024 • edited Loading

Description

How and where has this been tested?

Validation steps

Regression testing

To-do list

changeset-bot bot commented Oct 29, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Oct 29, 2024 • edited Loading

github-actions bot commented Oct 29, 2024 • edited Loading

File metrics

Summary

checkbox

dial

slider

castastrophe left a comment

Choose a reason for hiding this comment

marissahuysentruyt left a comment

Choose a reason for hiding this comment

marissahuysentruyt left a comment

Choose a reason for hiding this comment

cdransf commented Oct 29, 2024 •

edited

Loading

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading