Skip to content

chore(treeview): remove unused custom property to resolve lint violation #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 23, 2024

Description

Use custom property in place of direct value when defining mod.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: c2ca3f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/treeview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf self-assigned this Oct 23, 2024
@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 23, 2024
@cdransf cdransf requested review from castastrophe, jawinn and 5t3ph and removed request for castastrophe October 23, 2024 22:28
Copy link
Contributor

github-actions bot commented Oct 23, 2024

🚀 Deployed on https://pr-3318--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 23, 2024

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🔴 ⬆ 0.14 KB (0.00%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
treeview 17.21 KB 🔴 ⬆ 0.05 KB

Details

treeview

Filename Head Compared to base
index-base.css 17.21 KB 🔴 ⬆ 0.05 KB (0.26%)
index-vars.css 17.21 KB 🔴 ⬆ 0.05 KB (0.26%)
index.css 17.21 KB 🔴 ⬆ 0.05 KB (0.26%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf force-pushed the cdransf/stylelint-treeview branch from 42ba97c to bec9cdd Compare October 24, 2024 20:07
@cdransf cdransf requested a review from jawinn October 24, 2024 20:08
@cdransf cdransf force-pushed the cdransf/stylelint-treeview branch from bec9cdd to 6d9d8fc Compare October 24, 2024 21:45
@cdransf cdransf requested a review from 5t3ph October 24, 2024 21:53
@cdransf cdransf requested a review from jawinn October 27, 2024 17:45
@castastrophe castastrophe force-pushed the cdransf/stylelint-treeview branch from 0d1eb51 to f2dc289 Compare October 28, 2024 13:14
@castastrophe castastrophe force-pushed the cdransf/stylelint-treeview branch from f2dc289 to d3722f9 Compare October 28, 2024 16:12
@cdransf cdransf force-pushed the cdransf/stylelint-treeview branch 5 times, most recently from 3e76fb5 to eeb8eba Compare October 28, 2024 17:29
@cdransf cdransf force-pushed the cdransf/stylelint-treeview branch from eeb8eba to c2ca3f7 Compare October 28, 2024 18:00
@cdransf cdransf merged commit d8d0450 into main Oct 28, 2024
12 checks passed
@cdransf cdransf deleted the cdransf/stylelint-treeview branch October 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants