Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tag): adjust custom property order to resolve lint violations #3307

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 22, 2024

Description

Reorder rules and custom properties to resolve lint violations.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 22, 2024
@cdransf cdransf self-assigned this Oct 22, 2024
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 88e523a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/tag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf force-pushed the cdransf/stylelint-tag branch from 0d58436 to 9724ec0 Compare October 22, 2024 18:34
Copy link
Contributor

github-actions bot commented Oct 22, 2024

🚀 Deployed on https://pr-3307--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 22, 2024

File metrics

Summary

Total size: 4.30 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the cdransf/stylelint-tag branch from 9724ec0 to 30c35fb Compare October 22, 2024 21:08
@cdransf cdransf force-pushed the cdransf/stylelint-tag branch from 30c35fb to 88e523a Compare October 22, 2024 23:31
@cdransf cdransf added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 22, 2024
@cdransf cdransf merged commit 25ddd5e into main Oct 23, 2024
18 of 24 checks passed
@cdransf cdransf deleted the cdransf/stylelint-tag branch October 23, 2024 00:05
This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants