Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sidenav): move declaration, add description and apply token #3296

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore(sidenav): move declaration, add description and apply token #3296

merged 1 commit into from
Oct 23, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 22, 2024

Description

Resolve stylelint violations by moving declaration and adding comment as stylelint disable description.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 22, 2024
@cdransf cdransf self-assigned this Oct 22, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8cbf7b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/sidenav Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

🚀 Deployed on https://pr-3296--spectrum-css.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🔴 ⬆ 0.35 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
sidenav 14.58 KB 🔴 ⬆ 0.12 KB

Details

sidenav

Filename Head Compared to base
index-base.css 14.58 KB 🔴 ⬆ 0.12 KB (0.78%)
index-vars.css 14.58 KB 🔴 ⬆ 0.12 KB (0.78%)
index.css 14.58 KB 🔴 ⬆ 0.12 KB (0.78%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf changed the title chore(stylelint): move declaration + adjust comment to resolve violations chore(sidenav): move declaration + adjust comment to resolve violations Oct 22, 2024
@cdransf cdransf force-pushed the cdransf/stylelint-sidenav branch from 46e4bd8 to 8b2953e Compare October 22, 2024 16:44
castastrophe
castastrophe requested changes Oct 22, 2024
View reviewed changes
components/sidenav/index.css Outdated Show resolved Hide resolved
@cdransf cdransf force-pushed the cdransf/stylelint-sidenav branch 3 times, most recently from 181bac4 to 20137c5 Compare October 23, 2024 16:16
@cdransf cdransf changed the title chore(sidenav): move declaration + adjust comment to resolve violations move declaration, add description and apply token Oct 23, 2024
@cdransf cdransf changed the title move declaration, add description and apply token chore(sidenav): move declaration, add description and apply token Oct 23, 2024
@cdransf cdransf added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 23, 2024
@cdransf cdransf requested a review from castastrophe October 23, 2024 16:17
@cdransf cdransf force-pushed the cdransf/stylelint-sidenav branch from 20137c5 to 6b9a3f6 Compare October 23, 2024 16:30
castastrophe
castastrophe requested changes Oct 23, 2024
View reviewed changes
components/sidenav/index.css Outdated Show resolved Hide resolved
@cdransf cdransf force-pushed the cdransf/stylelint-sidenav branch 2 times, most recently from afa574d to b2471e3 Compare October 23, 2024 18:38
@cdransf cdransf requested a review from castastrophe October 23, 2024 18:45
@cdransf cdransf force-pushed the cdransf/stylelint-sidenav branch from b2471e3 to 8cbf7b7 Compare October 23, 2024 20:38
@cdransf cdransf merged commit 83d2df9 into main Oct 23, 2024
14 checks passed
@cdransf cdransf deleted the cdransf/stylelint-sidenav branch October 23, 2024 20:54
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@5t3ph 5t3ph Awaiting requested review from 5t3ph

@rise-erpelding rise-erpelding Awaiting requested review from rise-erpelding

@marissahuysentruyt marissahuysentruyt Awaiting requested review from marissahuysentruyt

Assignees

@cdransf cdransf

Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdransf @castastrophe