-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(datepicker): reduce nesting to resolve lint violation #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdransf
added
size-1 XS
~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
wip
This is a work in progress, don't judge.
skip_vrt
Add to a PR to skip running VRT (but still pass the action)
labels
Oct 21, 2024
🦋 Changeset detectedLatest commit: 5018c97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3285--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.30 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
approved these changes
Oct 21, 2024
cdransf
force-pushed
the
cdransf/stylelint-datepicker-nesting-fix
branch
from
October 21, 2024 19:37
a607f75
to
cbcf076
Compare
castastrophe
changed the title
chore(stylelint): reduce nesting to resolve lint violation
fix(datepicker): reduce nesting to resolve lint violation
Oct 21, 2024
cdransf
force-pushed
the
cdransf/stylelint-datepicker-nesting-fix
branch
from
October 21, 2024 23:40
cbcf076
to
f29bc04
Compare
cdransf
changed the title
fix(datepicker): reduce nesting to resolve lint violation
chore(datepicker): reduce nesting to resolve lint violation
Oct 22, 2024
cdransf
force-pushed
the
cdransf/stylelint-datepicker-nesting-fix
branch
from
October 22, 2024 16:42
f29bc04
to
fdd0d44
Compare
aramos-adobe
approved these changes
Oct 22, 2024
cdransf
force-pushed
the
cdransf/stylelint-datepicker-nesting-fix
branch
from
October 22, 2024 20:25
fdd0d44
to
5018c97
Compare
This was referenced Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves lint violation in datepicker by adjusting nesting depth.
To-do list