Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datepicker): reduce nesting to resolve lint violation #3285

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 21, 2024

Description

Resolves lint violation in datepicker by adjusting nesting depth.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. wip This is a work in progress, don't judge. skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 21, 2024
@cdransf cdransf self-assigned this Oct 21, 2024
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 5018c97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/datepicker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

🚀 Deployed on https://pr-3285--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 21, 2024

File metrics

Summary

Total size: 4.30 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf marked this pull request as ready for review October 21, 2024 19:32
@cdransf cdransf force-pushed the cdransf/stylelint-datepicker-nesting-fix branch from a607f75 to cbcf076 Compare October 21, 2024 19:37
@cdransf cdransf requested a review from aramos-adobe October 21, 2024 19:44
@castastrophe castastrophe changed the title chore(stylelint): reduce nesting to resolve lint violation fix(datepicker): reduce nesting to resolve lint violation Oct 21, 2024
@cdransf cdransf force-pushed the cdransf/stylelint-datepicker-nesting-fix branch from cbcf076 to f29bc04 Compare October 21, 2024 23:40
@cdransf cdransf changed the title fix(datepicker): reduce nesting to resolve lint violation chore(datepicker): reduce nesting to resolve lint violation Oct 22, 2024
@cdransf cdransf force-pushed the cdransf/stylelint-datepicker-nesting-fix branch from f29bc04 to fdd0d44 Compare October 22, 2024 16:42
@cdransf cdransf force-pushed the cdransf/stylelint-datepicker-nesting-fix branch from fdd0d44 to 5018c97 Compare October 22, 2024 20:25
@cdransf cdransf merged commit 727ccd0 into main Oct 22, 2024
12 checks passed
@cdransf cdransf deleted the cdransf/stylelint-datepicker-nesting-fix branch October 22, 2024 20:32
This was referenced Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) wip This is a work in progress, don't judge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants