Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typography): fallback sizing for detail at xxs #3249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(typography): fallback sizing for detail at xxs #3249

wants to merge 1 commit into from
+4 −0

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 14, 2024 •
edited
Loading

Description

I noticed in the visual regression tests that the detail heading is still showing at default medium sizing when at "XXS"; ideally it should default to "S".

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Expect the testing grid to show the detail heading as --sizeS at the "XXS" sizing set.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added testing Visual regression testing size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. run_vrt For use on PRs looking to kick off VRT storybook ready-for-review s1 labels Oct 14, 2024
@castastrophe castastrophe self-assigned this Oct 14, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8af4970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

🚀 Deployed on https://pr-3249--spectrum-css.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

File metrics

Summary

Total size: 4.31 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Oct 14, 2024
@castastrophe
Copy link
Collaborator Author

VRTs were run and showed the appropriate changes 🥳

@castastrophe castastrophe force-pushed the chore-detail-heading-fallback-template branch from 4f1a058 to 8af4970 Compare October 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5t3ph 5t3ph 5t3ph approved these changes

Assignees

@castastrophe castastrophe

Labels
ready-for-review s1 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) storybook testing Visual regression testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@castastrophe @5t3ph