-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(meter): let meter use its rootclass in storybook #3231
Conversation
|
File metricsSummaryTotal size: 4.31 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
1e1a0b3
to
4c87ab0
Compare
🚀 Deployed on https://pr-3231--spectrum-css.netlify.app |
4c87ab0
to
eb69843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down! This definitely helps with the doc block PR!
Meter's Storybook template was using the rootClass for progress bar, rather than its own rootClass. It was set up this way because of the way the two components are housed together, and meter primarily just uses ProgressBar, with some added classes. This value not being unique made it difficult to compare and match up the value of rootClass in the packageJson spectrum data to the actual rootClass defined in the story files default args.
eb69843
to
a30fe10
Compare
Description
An update to the meter component storybook templates to help with simplifying the comparison between
rootClass
values in #3129. The Meter component was the only component using arootClass
arg value that is not unique and its own (previously it was usingspectrum-ProgressBar
).Details
Meter's Storybook template was using the
rootClass
for progress bar, rather than its ownrootClass
. It was set up this way because of the way the two components are housed together, and meter primarily just uses ProgressBar, with some added classes.This value not being unique made it difficult to compare and match up the value of
rootClass
in thepackage.json
spectrum
data to the actualrootClass
defined in the story files default args.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
spectrum-Meter--staticWhite
gets applied to the component root and the teal background still appears.Regression testing
Validate:
To-do list