feat(icons)!: s2 icons (workflow + ui) v2 #3001
Draft
+1,516
−873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9694a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3001--spectrum-css.netlify.app |
File metricsSummaryTotal size: 6.80 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
helptext
icon
illustratedmessage
infieldbutton
inlinealert
link
logicbutton
menu
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
site
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
jawinn
force-pushed
the
refactor-s2-icons-workflow-and-ui-v2
branch
from
988aa3a
to
420eb92
Compare
|
@jawinn Can we do a dry run in SWC? |
|
Typically we don't import @adobe/spectrum-tokens as a package in SWC. The icons in SWC are served separately via |
jawinn
force-pushed
the
refactor-s2-icons-workflow-and-ui-v2
branch
3 times, most recently
from
1c4f08b
to
8ddbce0
Compare
|
I've made a bunch of updates here to help prepare this for going into foundations:
|
8 tasks
jawinn
changed the title
Uses and updates to the latest icon sets for S2. ==== Workflow icons ==== Uses the latest version of this package. There is a large difference between the set of icons available for S1 and S2. These differences are documented separately from this work. ==== UI icons ==== Updates the ui-icons package with the latest set of icons. This includes deprecations and some new icons. See the change log for a full list of changes. The UI icons no longer contain both a medium and a large SVG asset. The file structure and loading have been changed to use the single asset.
jawinn
force-pushed
the
refactor-s2-icons-workflow-and-ui-v2
branch
from
8ddbce0
to
c9694a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses and updates to the latest icon sets for S2.
🚨 This is a breaking change.
Workflow icons
Uses the latest version of this package. There is a large difference between the set of icons available for S1 and S2. These differences are documented separately from this work.
UI icons
Updates the
ui-iconspackage with the latest set of icons. This includes deprecations and some new icons. See the change set in this PR for a full list of changes.The UI icons no longer contain both a medium and a large SVG asset. The file structure and loading have been changed to use the single asset.
Icon component storybook updates
Adds additional templates for displaying and testing the different icon sets. Includes a grid with sizing numbers in the Default story Chromatic template that displays UI icons. See screenshots below.
TO-DO:
History
This branch is a rebased and updated version of #2836 that:
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
WIP
Regression testing
Validate:
Screenshots
Default story's updated Chromatic template:
Story: list of workflow icons:
Story: list of UI icons:
To-do list