-
Notifications
You must be signed in to change notification settings - Fork 207
fix(icon): remove legacy ie overflow css causing ios clipping issues #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 879f318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 4.63 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsicon
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2974--spectrum-css.netlify.app |
b0f116c to
f222edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked both our prod open source icon storybook and the preview url in Chrome, Firefox, Safari and Edge on Mac, then Edge & Firefox on Windows via assistiv labs. I toggled the Express context and Large scale and didn't see any clipping on our end 👍
If I get all the way into the SWC storybook, I found examples of the Express icon clipping and saw the overflow: hidden code. I don't think this fix would be immediately visible via the preview link though (since it wouldn't be released yet for SWC to take in, right?), so I don't think I should be surprised that I still see the clipping. Hopefully this will improve it for them, and in turn Express!
It was reported that this normalize CSS for IE 9/10/11, in SWC which converts to the selector :host(:not(:root)), was causing problems with clipping in iOS mobile for Express as well as on Safari on MacOS. This is safe to remove as the project does not support IE 11.
f222edb to
879f318
Compare
Description
It was reported that this normalize CSS for IE 9/10/11, which Spectrum Web Components converts to the selector
:host(:not(:root)), was leading to "clipping on iOS mobile (for Express) as well as on Safari on MacOS". An Express-specific hotfix was already put in to override this overflow declaration.This is safe to remove as the project does not support IE 11.
Reference:
The original
necolas/normalize.csshas this normalization labeled as "Correct overflow not hidden in IE 9/10/11."CSS-700
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
@marissahuysentruyt
Regression testing
Validate:
To-do list