-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify usage of very low opacity on some inputs #2963
Conversation
|
🚀 Deployed on https://pr-2963--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.63 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
088c1f5
to
f640bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for leaving these comments! This will come in handy in the future when we look back to refactor these :-)
Adds some comments to clarify existing CSS that uses a low opacity (0.0001 and 0.000001) for visually hidden inputs. And explains why they are hidden this way and not with a type of sr-only class.
f640bf4
to
bc29915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- thanks for researching this and leaving some explanations!
Description
Adds some comments to clarify existing CSS that uses a low opacity (0.0001 and 0.000001) for visually hidden inputs. And explains why they are hidden this way with sizing and positioning for touch users, instead of using a screenreader only (.sr-only) technique.
Reference info:
opacity: 0
elements are included in the accessibility tree.At some point in the future we may want to look at dropping the very low opacity in favor of
opacity: 0
. I cannot find any official change log available that references exactly when the ChromeVox issue was fixed.CSS-814
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list