Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify usage of very low opacity on some inputs #2963

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Aug 1, 2024

Description

Adds some comments to clarify existing CSS that uses a low opacity (0.0001 and 0.000001) for visually hidden inputs. And explains why they are hidden this way with sizing and positioning for touch users, instead of using a screenreader only (.sr-only) technique.

Reference info:

At some point in the future we may want to look at dropping the very low opacity in favor of opacity: 0. I cannot find any official change log available that references exactly when the ChromeVox issue was fixed.

CSS-814

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Validate that explanation and wording are correct

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: bc29915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 1, 2024

🚀 Deployed on https://pr-2963--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Aug 1, 2024

File metrics

Summary

Total size: 4.63 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@jawinn jawinn changed the title docs: comments to clarify usage of very low opacity on some inputs docs: clarify usage of very low opacity on some inputs Aug 1, 2024
@jawinn jawinn added ready-for-review documentation Because documentation is important and shouldn't be broken size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. low priority Not a critical update or fix; can be deprioritized if necessary labels Aug 1, 2024
@jawinn jawinn force-pushed the jawinn/css-814-low-opacity-documentation branch from 088c1f5 to f640bf4 Compare August 5, 2024 18:05
@pfulton pfulton self-requested a review August 5, 2024 18:53
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leaving these comments! This will come in handy in the future when we look back to refactor these :-)

Adds some comments to clarify existing CSS that uses a low opacity
(0.0001 and 0.000001) for visually hidden inputs. And explains why they
are hidden this way and not with a type of sr-only class.
@pfulton pfulton force-pushed the jawinn/css-814-low-opacity-documentation branch from f640bf4 to bc29915 Compare August 5, 2024 18:54
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- thanks for researching this and leaving some explanations!

@pfulton pfulton merged commit edb515b into main Aug 5, 2024
22 of 24 checks passed
@pfulton pfulton deleted the jawinn/css-814-low-opacity-documentation branch August 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Because documentation is important and shouldn't be broken low priority Not a critical update or fix; can be deprioritized if necessary ready-to-merge size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants