Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(popover, progresscircle, radio, rating, sidenav): site docs to storybook #2883

Merged
merged 10 commits into from
Sep 5, 2024
Merged

docs(popover, progresscircle, radio, rating, sidenav): site docs to storybook #2883

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5c7ced3
docs: include a dash for the term read-only
jawinn Sep 3, 2024
a43cdc1
feat(storybook): maintain unique name and id args in sizes arggrid
jawinn Aug 27, 2024
727d79f
docs(progresscircle): migrate docs to storybook
jawinn Jun 21, 2024
0607e41
docs(radio): migrate docs to storybook
jawinn Jun 25, 2024
678e677
docs(fieldgroup): include missing role and aria-readonly attributes
jawinn Jun 25, 2024
bb3c9a9
docs(rating): migrate docs to storybook and stories cleanup
jawinn Jun 25, 2024
7ccb391
docs(sidenav): improve storybook documentation and migrate docs page
jawinn Jun 26, 2024
41e6080
docs(popover): docs page to storybook migration
jawinn Jun 28, 2024
d585449
docs(rating): remove unsupported readonly attribute from template
jawinn Jul 29, 2024
64cba0e
docs(rating): fix incorrect focus class being applied in storybook
jawinn Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(rating): fix incorrect focus class being applied in storybook 
The focused class was named wrong and was being applied to the wrong
element.
  • Loading branch information
@jawinn
jawinn committed Sep 5, 2024
commit 64cba0e2478adcda1b5d86ef0166d6b60777ffca
2 changes: 1 addition & 1 deletion components/rating/stories/template.js
View file
Open in desktop
jawinn marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const Template = ({
[rootClass]: true,
"is-disabled": isDisabled,
"is-readOnly": isReadOnly,
"is-focused": isFocused,
[`${rootClass}--emphasized`]: isEmphasized,
...customClasses.reduce((a, c) => ({ ...a, [c]: true }), {}),
})}
Expand All @@ -40,7 +41,6 @@ export const Template = ({
<input
class=${classMap({
[`${rootClass}-input`]: true,
["is-Focus"]: isFocused,
})}
type="range"
min="0"
Expand Down
Loading