Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helptext): s2 migration #2723

Open
wants to merge 42 commits into
base: spectrum-two
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d669cad
feat(tokens): use 13.0.0-beta.5
pfulton Dec 11, 2023
0aa513a
feat(tokens): use 13.0.0-beta.8
pfulton Jan 8, 2024
07288a5
feat(tokens): use 13.0.0-beta.9
pfulton Jan 11, 2024
5c63236
feat(actiongroup)!: migrate to S2 (#2453)
mdt2 Feb 2, 2024
d86f546
feat(buttongroup)!: migrate to S2 (#2457)
jenndiaz Feb 2, 2024
84b5782
feat(tokens)!: use 13.0.0-beta.13
pfulton Feb 2, 2024
84f5d56
chore(release): release
pfulton Feb 6, 2024
a944f02
feat(tokens)!: use spectrum-tokens 13.0.0-beta.16
pfulton Feb 22, 2024
3f93a1c
chore(actiongroup,buttongroup): specify s2 tokens for peerdeps
pfulton Feb 26, 2024
226fe51
feat(closebutton)!: migrate to S2 (#2564)
mdt2 Mar 7, 2024
4aab1e6
chore: s2 grays component-level migration (#2583)
pfulton Mar 7, 2024
417899c
fix(closebutton): use correct casing for class names
pfulton Mar 8, 2024
29165d2
fix(commons): remove renamed mods marked for deprecation (#2580)
jawinn Mar 8, 2024
e37daed
feat(fieldlabel)!: s2 migration (#2569)
jawinn Mar 11, 2024
4d8f0e0
chore(tokens): use spectrum-tokens v13.0.0-beta.19
pfulton Mar 11, 2024
d1e35b1
chore(tokens): manual version bump for 14.0.0-next.1
pfulton Mar 12, 2024
532db71
chore(release): release
pfulton Mar 12, 2024
edd8382
feat(downstate): docs + implementation for example components (#2520)
mdt2 Mar 19, 2024
f9712d1
fix(button): resolve merge issue
pfulton Mar 19, 2024
96a6ff7
feat(tokens): use spectrum-tokens 13.0.0-beta.21 (#2597)
pfulton Mar 19, 2024
a3248be
chore(release): release
pfulton Mar 21, 2024
ef2fb76
chore: rebase against main and update components to use prerelease to…
pfulton Mar 28, 2024
aaf738d
feat(cornerrounding): add custom token and foundations documentation …
jenndiaz Mar 28, 2024
b3fdaa7
fix(storybook): body classes for story and docs pages (#2617)
mdt2 Apr 1, 2024
d4e4bad
docs: update migration guide headings (#2638)
jawinn Apr 4, 2024
5415aaa
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
mdt2 Apr 8, 2024
5628c92
feat(tokens): use spectrum-tokens at v13.0.0-beta.24 (#2650)
mdt2 Apr 9, 2024
f8fc7bc
chore(tokens): manual version bump for prerelease
pfulton Apr 9, 2024
408fbb7
feat: add example gradients for static black and white (#2637)
jawinn Apr 11, 2024
9bbb488
chore(tokens): use spectrum-tokens@13.0.0-beta.27
pfulton Apr 12, 2024
ff0645a
chore(release): release
pfulton Apr 12, 2024
357218a
feat(switch): s2 migration (#2651)
mdt2 Apr 15, 2024
bfaea04
chore: prerelease mode for changesets
pfulton Apr 19, 2024
861b1e1
chore(tokens): use @adobe/spectrum-tokens@13.0.0-beta.30 (#2678)
pfulton Apr 19, 2024
9af0ec0
chore: remove darkest as SB option (#2679)
pfulton Apr 19, 2024
06d2ecf
chore: release (next) (#2680)
github-actions[bot] Apr 19, 2024
5122de8
chore: run branch through format; update pathing and fix errors (#2700)
castastrophe Apr 26, 2024
9252338
chore: release (next) (#2706)
github-actions[bot] Apr 26, 2024
fb29aab
chore: fix linting conflict vs. format
castastrophe Apr 26, 2024
3559678
feat(button): migrate to Spectrum 2 (#2600)
jawinn May 1, 2024
e0e0fd2
chore: release s2 button (next) (#2722)
github-actions[bot] May 1, 2024
c6a6f60
feat(helptext): s2 migration
mdt2 May 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(actiongroup)!: migrate to S2 (#2453)
BREAKING CHANGE: migrates `Action Group` to Spectrum 2, Removes some mod properties
  • Loading branch information
mdt2 authored and pfulton committed May 1, 2024
commit 5c63236cef5c52631e6d58ad6a0d68944440d39e
24 changes: 1 addition & 23 deletions components/actiongroup/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ governing permissions and limitations under the License.
--spectrum-actiongroup-button-spacing-reset: 0;
--spectrum-actiongroup-border-radius-reset: 0;
--spectrum-actiongroup-border-radius: var(--spectrum-corner-radius-100);
--spectrum-actiongroup-gap-size-compact: var(--spectrum-spacing-50);
}

.spectrum-ActionGroup--sizeXS,
Expand Down Expand Up @@ -76,15 +77,6 @@ governing permissions and limitations under the License.

border-start-start-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
border-end-start-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
margin-inline-start: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
}

& + .spectrum-ActionGroup-item {
/* Action button passthrough styling */
--mod-actionbutton-focus-indicator-border-radius: 0px;

margin-inline-start: var(--mod-actiongroup-horizontal-spacing-compact, var(--spectrum-actiongroup-horizontal-spacing-compact));
margin-inline-end: var(--mod-actiongroup-horizontal-spacing-compact, var(--spectrum-actiongroup-horizontal-spacing-compact));
}

&:last-child {
Expand All @@ -93,8 +85,6 @@ governing permissions and limitations under the License.

border-start-end-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
border-end-end-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
margin-inline-start: var(--mod-actiongroup-horizontal-spacing-compact, var(--spectrum-actiongroup-horizontal-spacing-compact));
margin-inline-end: var(--mod-actiongroup-border-radius-reset, var(--spectrum-actiongroup-border-radius-reset));
}

&.is-selected {
Expand Down Expand Up @@ -128,16 +118,6 @@ governing permissions and limitations under the License.

border-start-start-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
border-start-end-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
margin-inline-end: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
margin-block-start: var(--mod-actiongroup-vertical-spacing-compact, var(--spectrum-actiongroup-vertical-spacing-compact));
margin-block-end: var(--mod-actiongroup-vertical-spacing-compact, var(--spectrum-actiongroup-vertical-spacing-compact));
}

& + .spectrum-ActionGroup-item {
margin-inline-start: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
margin-inline-end: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
margin-block-start: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
margin-block-end: var(--mod-actiongroup-vertical-spacing-compact, var(--spectrum-actiongroup-vertical-spacing-compact));
}

&:last-child {
Expand All @@ -146,8 +126,6 @@ governing permissions and limitations under the License.

border-end-start-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
border-end-end-radius: var(--mod-actiongroup-border-radius, var(--spectrum-actiongroup-border-radius));
margin-block-start: var(--mod-actiongroup-vertical-spacing-compact, var(--spectrum-actiongroup-vertical-spacing-compact));
margin-block-end: var(--mod-actiongroup-button-spacing-reset, var(--spectrum-actiongroup-button-spacing-reset));
}
}
}
Expand Down
3 changes: 0 additions & 3 deletions components/actiongroup/metadata/mods.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
| ---------------------------------------------- |
| `--mod-actiongroup-border-radius` |
| `--mod-actiongroup-border-radius-reset` |
| `--mod-actiongroup-button-spacing-reset` |
| `--mod-actiongroup-gap-size-compact` |
| `--mod-actiongroup-horizontal-spacing-compact` |
| `--mod-actiongroup-horizontal-spacing-regular` |
| `--mod-actiongroup-vertical-spacing-compact` |
| `--mod-actiongroup-vertical-spacing-regular` |
14 changes: 14 additions & 0 deletions components/actiongroup/stories/actiongroup.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,22 @@ Justified.args = {
content: items
};

export const JustifiedCompact = Template.bind({});
JustifiedCompact.args = {
justified: true,
compact: true,
content: items,
};

export const Quiet = Template.bind({});
Quiet.args = {
areQuiet: true,
content: items
};

export const QuietCompact = Template.bind({});
QuietCompact.args = {
areQuiet: true,
compact: true,
content: items,
};
7 changes: 0 additions & 7 deletions components/actiongroup/themes/express.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,4 @@ governing permissions and limitations under the License.
@import "./spectrum.css";

@container (--system: express) {
.spectrum-ActionGroup {
--spectrum-actiongroup-gap-size-compact: var(--spectrum-spacing-50);

/* account for button border */
--spectrum-actiongroup-horizontal-spacing-compact: calc(-1px * var(--spectrum-spacing-50));
--spectrum-actiongroup-vertical-spacing-compact: calc(-1px * var(--spectrum-spacing-50));
}
}
7 changes: 0 additions & 7 deletions components/actiongroup/themes/spectrum.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,4 @@ governing permissions and limitations under the License.
*/

@container (--system: spectrum) {
.spectrum-ActionGroup {
--spectrum-actiongroup-gap-size-compact: 0;

/* account for button border */
--spectrum-actiongroup-horizontal-spacing-compact: -1px;
--spectrum-actiongroup-vertical-spacing-compact: -1px;
}
}