Skip to content

chore(logicbutton,picker): align commons package #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Apr 1, 2024

Description

During rebase, the picker and logicbutton commons packages got out of sync with the version of commons on the branch. This re-aligns those versions.

To-do list

@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) S2 Spectrum 2 labels Apr 1, 2024
@castastrophe castastrophe self-assigned this Apr 1, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

🚀 Deployed on https://pr-2633--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Apr 1, 2024

File metrics

Summary

Total size: 4.49 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the ci-support-skipped-vrt branch from f3e8d24 to 4c000c0 Compare April 1, 2024 18:43
@castastrophe castastrophe force-pushed the ci-support-skipped-vrt branch from 4c000c0 to 4418ddf Compare April 1, 2024 20:51
@castastrophe castastrophe changed the title ci: support skipped vrt for build chore(logicbutton,picker): align commons package Apr 1, 2024
@castastrophe castastrophe requested a review from mdt2 April 1, 2024 20:52
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh these didn't get picked up in the most recent release of the spectrum-two branch because commons wasn't listed as a devDependency, is that why we have to do these manually?

@castastrophe castastrophe merged commit 9b745e7 into spectrum-two Apr 2, 2024
@castastrophe castastrophe deleted the ci-support-skipped-vrt branch April 2, 2024 15:01
@castastrophe castastrophe mentioned this pull request Apr 2, 2024
2 tasks
castastrophe added a commit that referenced this pull request Apr 3, 2024
castastrophe added a commit that referenced this pull request Apr 4, 2024
castastrophe added a commit that referenced this pull request Apr 5, 2024
castastrophe added a commit that referenced this pull request Apr 11, 2024
castastrophe added a commit that referenced this pull request Apr 11, 2024
pfulton pushed a commit that referenced this pull request Apr 12, 2024
pfulton pushed a commit that referenced this pull request Apr 15, 2024
castastrophe added a commit that referenced this pull request Apr 18, 2024
castastrophe added a commit that referenced this pull request Apr 18, 2024
pfulton pushed a commit that referenced this pull request Apr 19, 2024
pfulton pushed a commit that referenced this pull request Apr 19, 2024
castastrophe added a commit that referenced this pull request Apr 24, 2024
castastrophe added a commit that referenced this pull request Apr 26, 2024
castastrophe added a commit that referenced this pull request Apr 26, 2024
castastrophe added a commit that referenced this pull request Apr 30, 2024
castastrophe added a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants