Skip to content

feat(opacitycheckerboard): small t-shirt size squares #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pfulton merged 2 commits into from
Apr 8, 2024
Merged

feat(opacitycheckerboard): small t-shirt size squares #2610

pfulton merged 2 commits into from
Apr 8, 2024

Conversation

@mdt2
Copy link
Collaborator

@mdt2 mdt2 commented Mar 26, 2024 •
edited
Loading

Description

S2 migration for opacity checkerboard includes:

  • Updated checkerboard square size token for default t-shirt size (medium)
  • Addition of small t-shirt size with checkboard square size token

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Design review @mdt2 (approved in slack)
  • Storybook has small t-shirt size and new tokens

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

File metrics

Summary

Total size: 4.54 MB*
Total change (Δ): ⬆ 0.56 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
opacitycheckerboard 1.79 KB ⬆ 0.15 KB

Details

opacitycheckerboard

File Head Base Δ
index-base.css 1.79 KB 1.64 KB ⬆ 0.15 KB (8.73%)
index-vars.css 1.79 KB 1.64 KB ⬆ 0.15 KB (8.73%)
index.css 1.79 KB 1.64 KB ⬆ 0.15 KB (8.73%)
metadata.json 0.73 KB 0.61 KB ⬆ 0.12 KB (18.86%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

🚀 Deployed on https://pr-2610--spectrum-css.netlify.app

@pfulton pfulton self-requested a review March 27, 2024 14:16
pfulton
pfulton requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind doing some isChromatic magic to get both the small and medium sizes in VRT?

@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Mar 27, 2024
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from 7c86724 to 0a218bc Compare March 28, 2024 14:22
@castastrophe castastrophe added the S2 Spectrum 2 label Apr 1, 2024
@mdt2 mdt2 force-pushed the mdt2/css-718-s2-opacity-checkerboard branch from a51a490 to 074f47f Compare April 1, 2024 17:01
@mdt2 mdt2 added run_vrt For use on PRs looking to kick off VRT and removed run_vrt For use on PRs looking to kick off VRT labels Apr 1, 2024
@castastrophe castastrophe force-pushed the mdt2/css-718-s2-opacity-checkerboard branch from 074f47f to f1dfcc9 Compare April 1, 2024 18:05
@mdt2 mdt2 force-pushed the mdt2/css-718-s2-opacity-checkerboard branch from f1dfcc9 to 9e47645 Compare April 1, 2024 18:49
castastrophe
castastrophe reviewed Apr 1, 2024
View reviewed changes
@mdt2 mdt2 force-pushed the mdt2/css-718-s2-opacity-checkerboard branch from 384586b to e83b910 Compare April 1, 2024 21:02
@castastrophe
Copy link
Contributor

castastrophe commented Apr 3, 2024

Once you rebase this should pass the validate step

@mdt2
Copy link
Collaborator Author

mdt2 commented Apr 3, 2024

Once you rebase this should pass the validate step

Awesome, thanks @castastrophe! Also just a note that we're waiting for design validation on this one, I heard from the team today and they are taking a look this week.

@castastrophe castastrophe force-pushed the spectrum-two branch 2 times, most recently from 0f20c5b to 9ff2a2c Compare April 5, 2024 14:36
@mdt2 mdt2 force-pushed the mdt2/css-718-s2-opacity-checkerboard branch from e83b910 to 998a3eb Compare April 8, 2024 14:03
@pfulton pfulton merged commit d01474c into spectrum-two Apr 8, 2024
@pfulton pfulton deleted the mdt2/css-718-s2-opacity-checkerboard branch April 8, 2024 20:09
castastrophe pushed a commit that referenced this pull request Apr 11, 2024
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
c36ce0b 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Apr 30, 2024
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
07d78ad 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
pfulton pushed a commit that referenced this pull request May 1, 2024
@pfulton
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
5415aaa 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
pfulton pushed a commit that referenced this pull request May 3, 2024
@pfulton
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
7782c13 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
rise-erpelding pushed a commit that referenced this pull request May 7, 2024
@rise-erpelding
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
f819213 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
pfulton pushed a commit that referenced this pull request May 10, 2024
@pfulton
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
816686b 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Dec 27, 2024
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
0ba0810 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Dec 29, 2024
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
3a60b51 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Dec 29, 2024
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
3b0c098 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
aramos-adobe pushed a commit that referenced this pull request Jan 9, 2025
@aramos-adobe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
e919cb5 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Jan 17, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
96b8533 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Jan 17, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
9087d86 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Jan 21, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
4d6ae50 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Jan 22, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
fb48215 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 5, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
66ae6ab 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
083fdef 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
46f5f77 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
e20307f 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 11, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
92fe32b 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
101f57c 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
ab9174d 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
castastrophe pushed a commit that referenced this pull request Feb 25, 2025
@castastrophe
feat(opacitycheckerboard): S2, small t-shirt size squares (#2610)
e5a0e91 
* feat(opacitycheckerboard): small t-shirt size squares
* docs(opacitycheckerboard): chromatic coverage for t-shirt size
@castastrophe castastrophe mentioned this pull request Apr 15, 2025
Merged
12 tasks
This was referenced May 16, 2025
Merged
Merged
@castastrophe castastrophe mentioned this pull request Jul 25, 2025
Merged
3 tasks
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
Merged
11 tasks
This was referenced Aug 27, 2025
Closed
Closed
Closed
@castastrophe castastrophe mentioned this pull request Oct 22, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfulton pfulton pfulton approved these changes

+1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdt2 @castastrophe @pfulton