refactor(menu): adjust styling for disabled drill-in chevron #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File metricsSummaryTotal size: 3.94 MB*
Detailsmenu
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2550--spectrum-css.netlify.app |
jawinn
force-pushed
the
jawinn/refactor-menu-disabled-chevron
branch
from
33c8954 to
8ec2c71
Compare
jawinn
force-pushed
the
jawinn/refactor-menu-disabled-chevron
branch
2 times, most recently
from
10d37a2 to
792ceb0
Compare
The SWC implementation was having difficulty with making sure the chevron on a disabled drill-in menu item displayed as disabled, without overriding CSS. On the SWC end, the way a generic icon is styled is different from how chevrons or checkmarks are styled, so the styles added don't apply to the chevron. docs: remove docs change
Makes sure that a disabled menu item is represented in VRTs for the Collapsible variant. Sets one of the existing menu items to disabled.
jawinn
force-pushed
the
jawinn/refactor-menu-disabled-chevron
branch
from
792ceb0 to
4b322fb
Compare
|
Closing after a followup with SWC. This issue no longer is present in the current version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some difficulty was encountered with the SWC implementation making sure the chevron on a disabled drill-in menu item displayed as disabled, without overriding CSS. On the SWC end, the way a generic icon is styled is different from how chevrons or checkmarks are styled, so the styles added didn't apply to the chevron.
Discussion here #2199 (review)
Docs migration guide: also adds versions and dates to the existing migration guide content to conform with new recommended format.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list