-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(splitbutton): deprecate component #2527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-2527--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.93 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
mdt2/css-541-deprecate-split-button
branch
from
February 15, 2024 23:33
466dd88
to
77b17b3
Compare
mdt2
force-pushed
the
mdt2/css-541-deprecate-split-button
branch
from
February 16, 2024 15:50
77b17b3
to
5556437
Compare
castastrophe
force-pushed
the
mdt2/css-541-deprecate-split-button
branch
from
February 16, 2024 16:04
5556437
to
b8e468c
Compare
castastrophe
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note about the link and then we can merge this!
I also validated no regressions in Pagination button-style |
castastrophe
force-pushed
the
mdt2/css-541-deprecate-split-button
branch
from
February 16, 2024 16:16
b8e468c
to
1bd0d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating splitbutton. Setup for the deprecation was completed in #2526
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
components/
Regression testing
Validate:
Screenshots
To-do list