Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(splitbutton): deprecate component #2527

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

mdt2
Copy link
Collaborator

@mdt2 mdt2 commented Feb 15, 2024

Description

Deprecating splitbutton. Setup for the deprecation was completed in #2526

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Splitbutton shows deprecation message in the docs site
  • Splitbutton shows in the deprecated section in storybook
  • All splitbutton code has been removed from components/
  • Deprecation has followed the deprecation guidelines

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link
Contributor

github-actions bot commented Feb 15, 2024

🚀 Deployed on https://pr-2527--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Feb 15, 2024

File metrics

Summary

Total size: 3.93 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the mdt2/css-541-deprecate-split-button branch from 466dd88 to 77b17b3 Compare February 15, 2024 23:33
@mdt2 mdt2 force-pushed the mdt2/css-541-deprecate-split-button branch from 77b17b3 to 5556437 Compare February 16, 2024 15:50
@castastrophe castastrophe force-pushed the mdt2/css-541-deprecate-split-button branch from 5556437 to b8e468c Compare February 16, 2024 16:04
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about the link and then we can merge this!

@castastrophe
Copy link
Collaborator

I also validated no regressions in Pagination button-style

@castastrophe castastrophe force-pushed the mdt2/css-541-deprecate-split-button branch from b8e468c to 1bd0d54 Compare February 16, 2024 16:16
@castastrophe castastrophe enabled auto-merge (squash) February 16, 2024 16:18
@castastrophe castastrophe merged commit 5a61a2e into main Feb 16, 2024
19 of 21 checks passed
@castastrophe castastrophe deleted the mdt2/css-541-deprecate-split-button branch February 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants