docs: storybook updates for icon sets, arrow and chevron #2491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File metricsSummaryTotal size: 3.92 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2491--spectrum-css.netlify.app |
jawinn
force-pushed
the
jawinn/css-511-stories-ui-icon-sets
branch
from
9ea9fec to
584cb6f
Compare
Related fixes for Icon migration, that helps fix the wrong workflow icons appearing for arrow and chevron. These are both icons with names that exist in both icon sets. Some component stories need the icon set specified.
jawinn
force-pushed
the
jawinn/css-511-stories-ui-icon-sets
branch
from
584cb6f to
4d5e662
Compare
pfulton
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related component story fixes for a fix in the Icon migration #2347 , that helps fix the wrong workflow icons appearing for arrow and chevron.
These are both icons with names that exist in both icon sets. Some component stories need the icon set specified. These changes were cherry-picked from that PR to avoid breaking changes.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
If components have been modified, VRTs have been run on this branch:
To-do list