Skip to content

feat(backgroundlayers): class based implementation #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: spectrum-two
Choose a base branch
from

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Dec 13, 2023

Description

Creates utility classes which can be used by adding background layers to the dependencies for the component and then using the classes where needed.

Changes:

  • Created a utility like "component" for background layers. This should eventually live in it's own section of the docs site. I didn't focus too much on navigation for the docs site or editing the nav.pug file.
  • index.css has classes for each of the layers specified in the specs for background layers which can be used directly
  • class names intentionally include the context it should be used in, editting vs browsing
  • In storybook background layers is in it's own section "utility classes"

View Comments from previous branch for background layers that is now closed: #2274

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

BREAKING CHANGE: Merges Express and Spectrum to create Spectrum 2
Includes new color values for Spectrum 2
@jenndiaz jenndiaz force-pushed the background-layers-class-based-approach branch from 61a87a1 to c9dadf3 Compare January 10, 2024 18:58
@pfulton pfulton force-pushed the spectrum-two branch 4 times, most recently from 31afc05 to 909f232 Compare January 22, 2024 20:15
@pfulton pfulton force-pushed the spectrum-two branch 3 times, most recently from 9a01c5a to 1b959b3 Compare February 5, 2024 21:12
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from 98335ab to fec70b3 Compare February 26, 2024 19:47
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from 7c86724 to 0a218bc Compare March 28, 2024 14:22
@castastrophe castastrophe force-pushed the spectrum-two branch 6 times, most recently from fc916f1 to 9d7f088 Compare December 29, 2024 19:50
@castastrophe castastrophe force-pushed the spectrum-two branch 4 times, most recently from 7e783b6 to e3585cd Compare January 22, 2025 17:44
@castastrophe castastrophe force-pushed the spectrum-two branch 2 times, most recently from 56c6806 to 793571c Compare February 5, 2025 17:33
@castastrophe castastrophe force-pushed the spectrum-two branch 7 times, most recently from dee81f5 to ce2f3e0 Compare February 11, 2025 19:53
@castastrophe castastrophe force-pushed the spectrum-two branch 6 times, most recently from 3499231 to ad861d0 Compare February 25, 2025 20:24
@castastrophe castastrophe force-pushed the spectrum-two branch 3 times, most recently from 7e8269c to 4ce8d19 Compare May 5, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants