-
Notifications
You must be signed in to change notification settings - Fork 201
chore(ci): update compare assets processing #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8158c71
to
a92cf49
Compare
File metricsSummaryTotal size: 3.61 MB* 🎉 No changes detected in any packages * An ASCII character in UTF-8 is 8 bits or 1 byte. |
a3eb7cd
to
d1538d9
Compare
🚀 Deployed on https://pr-2337--spectrum-css.netlify.app |
b536d71
to
b499b29
Compare
b499b29
to
ef63370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. The only command I'm not sure about is yarn clean:components
. In the console I see The following projects do not have a configuration for any of the provided targets ("clean")
, is this expected?
ef63370
to
699ae34
Compare
That does not sound right. Let me poke at that. Thanks for checking it! |
6a55b02
to
3cd6641
Compare
Alright, this has now been fixed by adding the clean command to each package.json. This will be a relatively short-lived fix since we'll be moving all scripts to be run by project.json & nx.json definitions but it gets us off lerna for running commands since nx & lerna's caches don't play well together. |
3cd6641
to
d377349
Compare
d377349
to
217b788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
"*.css": [ | ||
"stylelint --fix --quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little leery of this, just because we had some problems the last time. Let's move forward with this for now, but keep an eye on it for issues, please!
Description
A lightweight update to:
How and where has this been tested?
No regressions for the following commands (tested by @mdt2):
yarn dev
yarn start
yarn build:preview
.storybook/storybook-static
, then ranyarn build:preview
which builtstorybook-static
. Then I ranyarn start
and confirmed that what was built is working as expected locally.yarn build:components
yarn clean:components
To-do list