fix(storybook): postcss parsing error for node_modules paths #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
force-pushed
the
fix-storybook-parsing-error-in-postcss
branch
from
609e676 to
4f5272a
Compare
castastrophe
added
run_vrt
File metricsOverall Δ: No change 🎉 🎉 |
|
🚀 Deployed on https://pr-2321--spectrum-css.netlify.app |
pfulton
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a typo in the postcss.config.js for storybook where it was not capturing the foldername accurately. If the package existed in the node_modules folder, it was returning
../instead of the foldername as expected. This means the tokens were not running through the postcss parsing they were supposed to that adds the.spectrum--expressmodifier and allows us to support loading styles for vars & expressvars at the same time. This led to coachmark and searchwithin to loading the expressvars stylesheet when taking baseline snapshots and failing VRT.How and where has this been tested?
Screenshots
To-do list