Skip to content

chore: patch storybook build for ci #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Nov 15, 2023

Description

When building the static storybook, a stray ../ (which is represented in webpack with _/) is messing with the pathing to the vars & expressvars. This should correct for that.

How and where has this been tested?

CI 🎈

Validation steps

  • CI successfully build storybook

Regression testing

  • No local storybook regressions

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link
Contributor

File metrics

Overall Δ: No change 🎉 🎉

Copy link
Contributor

🚀 Deployed on https://pr-2303--spectrum-css.netlify.app

Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@castastrophe castastrophe merged commit f37c493 into main Nov 15, 2023
@castastrophe castastrophe deleted the chore-patch-storybook-build-for-ci branch November 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants