Skip to content

chore(ci): remove dynamically named ci so we can require it for pull requests #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

castastrophe
Copy link
Collaborator

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe force-pushed the chore-generically-named-ci branch from a366666 to 04c5299 Compare November 9, 2023 22:12
@castastrophe castastrophe force-pushed the chore-generically-named-ci branch from 04c5299 to 01e397d Compare November 9, 2023 22:13
@castastrophe castastrophe merged commit bfa9f0d into main Nov 9, 2023
@castastrophe castastrophe deleted the chore-generically-named-ci branch November 9, 2023 22:17
Copy link
Contributor

github-actions bot commented Nov 9, 2023

File metrics

Overall Δ: No change 🎉 🎉

Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚀 Deployed on https://pr-2287--spectrum-css.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant