feat(card): add additional mod properties #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2279--spectrum-css.netlify.app |
jawinn
force-pushed
the
jawinn/css-628-card-mod-properties
branch
from
d5cec26 to
3c4077a
Compare
Additional --mod custom properties were needed to customize the invididual paddings and margins for the card body. Also added for the card footer. Two custom properties have been renamed and marked as deprecated, with a fallback to the old mod name for the time being.
jawinn
force-pushed
the
jawinn/css-628-card-mod-properties
branch
from
3c4077a to
9ac7247
Compare
File metricsOverall Δ: +1.72 KB ⬆ (+0.00%) card+1.72 KB ⬆
|
castastrophe
added a commit
that referenced
this pull request
Nov 10, 2023
Additional --mod custom properties were needed to customize the invididual paddings and margins for the card body. Also added for the card footer. Two custom properties have been renamed and marked as deprecated, with a fallback to the old mod name for the time being. Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional --mod custom properties were requested to customize the individual padding values for the card body. Mods have also been added for the card footer.
--mod-card-body-padding-block-end--mod-card-body-padding-block-start--mod-card-body-padding-inline-end--mod-card-body-padding-inline-start--mod-card-footer-margin-block-start--mod-card-footer-margin-inline-end--mod-card-footer-margin-inline-start--mod-card-footer-padding-block-end--mod-card-footer-padding-block-startTwo mod custom properties have been renamed and marked as deprecated, with a fallback to the old mod name for the time being.
--mod-card-title-padding-tophas been renamed to --mod-card-body-padding-block-startand will be removed in a future version--mod-card-footer-margin-tophas been renamed to--mod-card-footer-padding-block-startand will be removed in a future version.Note: One of the custom properties
--spectrum-card-footer-margin-topwas renamed as it actually referred to the padding top, not the margin top. This had been confusing because there are other custom properties that set the margin top.CSS-628
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
.spectrum-Card-bodyRegression testing
Validate:
To-do list