Skip to content

chore(alertdialog): adds custom tokens #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Aug 18, 2023

Description

Adds custom tokens needed for Alert Dialog #1862

--spectrum-alert-dialog-padding
--spectrum-alert-dialog-description-to-buttons

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

There should be no UI changes!

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  1. A migrated documentation page (such as action group), including:

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz requested a review from castastrophe August 18, 2023 13:54
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, just waiting on the PR checks to finish. @jenndiaz there's no small sizing correct?

@github-actions
Copy link
Contributor

🚀 Deployed on https://pr-2101--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 14:02 Inactive
@jenndiaz
Copy link
Contributor Author

@castastrophe correct no small sizing, in this case Medium is Desktop and Large is Mobile.

@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Aug 18, 2023
@castastrophe castastrophe enabled auto-merge (squash) August 18, 2023 14:06
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Aug 18, 2023
@castastrophe castastrophe merged commit c77140d into main Aug 18, 2023
@castastrophe castastrophe deleted the jenndiaz/custom-tokens-for-alert-dialog branch August 18, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants