fix(opacitycheckboard): add to component stories #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2056--spectrum-css.netlify.app |
pfulton
approved these changes
Jul 31, 2023
- Modify storybook template so that it can be imported and used by other components' stories. Allow passing in content, and excluding the storybook testing wrapper markup. - Moves defaultValue to args, as that syntax has been deprecated in newer versions of Storybook: https://storybook.js.org/docs/react/api/arg-types#defaultvalue - Adds a new story with a centered background position mod, and clarifies that the arg is changing the mod.
pfulton
force-pushed
the
jenndiaz/add-opacitycheckboard-to-stories
branch
from
7308bbc to
246a196
Compare
jawinn
suggested changes
Jul 31, 2023
jawinn
reviewed
Jul 31, 2023
Colorhandle had lost some of the classes being passed to it. They needed to be passed down to the new OpacityCheckerboard story template.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds opacity checkerboard to the stories for Swatch, ColorHandle, and Thumbnail
Adjusts markup for Thumbnail component
adds transparent story to swatch
OpacityCheckerboard:
The OpacityCheckerboard story template is modified, so it can accept content as an arg and exclude the wrapper, so that it can be used in the ColorSlider story, and other components' stories. Also makes some other minor adjustments and adds a story. @jawinn
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Test outline:
Open the storybook for the Thumbnail component:
Open the Docs Site for the Thumbnail component:
Open the storybook for the Swatch component:
Open the storybook for the ColorHandle component:
Open the storybook for the Opacity Checkerboard component:
All tests completed by @jawinn
Regression testing
Validate:
All regression tests completed by @jawinn
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨