fix(rum-api-client): human readable error messages for the failed bundler api calls #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekremney
changed the title
|
This PR will trigger a minor release when merged. |
rpapani
reviewed
Mar 14, 2025
| try { | ||
| return await response.json(); | ||
| } catch (error) { | ||
| throw new Error(`Error parsing JSON from ${sanitizeURL(response.url)}: ${error.message}`); |
There was a problem hiding this comment.
@ekremney does this bubble up the error to the caller? Can we record all the failed urls and return the list of failed urls along with fetched bundles? Or can we introduce ignoreErrors option and ignore the errors and return the fetched bundles only? I don't want to fail the entire RUM bundles request if we can't get some bundles.. in almost all of the scenarios we're ok to calculate the insights we need with available data.
|
@ekremney any chance you can look into Ravi's suggestion in the PR? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[to be merged after the code freeze]
This PR introduces human readable error messages for the failed RUM Bundler API calls.
For example: