Tokowaka - Added suport for regex #1218
Merged
+621
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger no release when merged. |
…e/spacecat-shared into feat/tokowaka-regex-support
nit23uec
reviewed
Dec 8, 2025
| ); | ||
|
|
||
| if (patches.length === 0) { | ||
| // For prerender opportunities, allow configs with no patches (prerender-only) |
Contributor
There was a problem hiding this comment.
I think we should have one method in the mapper interface:
allowConfigsWithoutPatch (that can return false in base mapper).
this way we dont leak opportunity type info in main logic.
nit23uec
reviewed
Dec 9, 2025
| // For prerender, allow configs with no patches (prerender-only config) | ||
| const isPrerenderOnly = opportunity.getType() === 'prerender' && newConfig.patches.length === 0; | ||
|
|
||
| if (!isPrerenderOnly && (!newConfig.patches || newConfig.patches.length === 0)) { |
Contributor
There was a problem hiding this comment.
shouldn;t we use the mapper.allowConfigsWithoutPatch
Contributor
Author
There was a problem hiding this comment.
yes, added in preview also
nit23uec
reviewed
Dec 9, 2025
| } | ||
|
|
||
| if (!existingConfig.patches) { | ||
| this.log.warn(`No patches found in configuration for URL: ${fullUrl}`); |
nit23uec
approved these changes
Dec 9, 2025
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-tokowaka-client-v1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.82.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: adobe/spacecat-audit-worker#1746
Related PR:
adobe/spacecat-api-service#1623
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!