feat: Get promise token for CS autofix requests #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinarublea
reviewed
Mar 26, 2025
solaris007
reviewed
Mar 26, 2025
|
Moved encryption related code to the IMS client for better re-use, see adobe/spacecat-shared#667 |
solaris007
approved these changes
Apr 3, 2025
|
🎉 This PR is included in version 1.103.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sites of delivery type cloud service a promise token needs to be stored in the autofix job to be able to authenticate against the cloud service AEM instance.
This PR uses the IMS Promise client to exchange the user's token against a promise token which is stored in the sqs message payload to be used in the autofix worker later on. The promise token is not considered a secret, but may be optionally encrypted using a shared secret.