Open
Conversation
Member
|
Thank you for your interest in this fix, I've commented here with some more context around why this was the behavior (i.e. screenreader announcements being interrupted when we added this behavior). We'll have to do this testing before moving forward with any possible API/code changes, but definitely feel free to try it out on your end in the meantime if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8007
This pull request initiates changes related to issue #8007. Users have expressed confusion when entering a query in the ComboBox and pressing Enter, leading to the suggestions menu closing—even with an exact match. To enhance usability, it's proposed that we auto-focus the first suggestion whenever the input text modifies.
Here are some points for discussion:
✅ Pull Request Checklist:
📝 Test Instructions:
I am utilizing the React Aria Components/ComboBox/Combo Box Example story found at (packages/react-aria-components/stories/ComboBox.stories.tsx). When the character 'F' is typed, the suggestion 'Foo' does not gain focus automatically. Also, upon typing 'Foo' and pressing enter, the window closes despite the first suggestion being an exact match."