Skip to content

Conversation

@reidbarber
Copy link
Member

  • Refined search sections: Removed Home link from the Overview section. Moved 'Getting Started' to Guides.
  • Fix Release and Blog post date sorting in the mobile search menu
  • Fix blog post videos to match old site (autoplay, controls, etc.)
  • Make Adobe/React Aria logo a link to homepage on mobile
  • Keep "All" category when "Icons" is selected in search menu
  • Convert relative links in markdown output from .html to .md.
  • Center Adobe/React Aria/Internationalized logos in cards in Safari
  • Fixed skeleton title logic for index page (shows "React Spectrum" instead of "Home)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 20, 2025

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about this one, if you select "Icons" is it supposed to show "All" instead?

  • Keep "All" category when "Icons" is selected in search menu

Also do you see missing illustrations in the search menu in Safari? Might be my Safari version?

Image

@reidbarber
Copy link
Member Author

reidbarber commented Nov 21, 2025

@LFDanLu

I'm not really sure about this one, if you select "Icons" is it supposed to show "All" instead?

Previously, if you started searching under components, 'All' would be added and selected. But then if you switched over to 'Icons' it would get removed, causing a layout shift.

Now, once 'All' gets added, it doesn't get removed.

And it is still the case that if you start your first search in 'Icons', 'All' won't get added/selected since you're explicitly wanting to search within that resource.

Also do you see missing illustrations in the search menu in Safari? Might be my Safari version?

Interesting, they're working for me in Safari 26.0.1. Let me know if you can provide more info about the version, and if you can see the SVG getting rendered anywhere hidden or if it has height/width 0.

Screenshot 2025-11-21 at 11 06 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants