fix: picker overflow bug #8419
Merged
fix: picker overflow bug #8419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
Jun 20, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Seems straight forward enough, verified the fix through your stories in the dscription
|
|
||
| export const AutocompleteSelect = () => ( | ||
| <Select style={{marginBottom: 40}}> | ||
| <Select style={{marginBottom: 40, position: 'relative'}}> |
Member
There was a problem hiding this comment.
I assume these story changes are just to make sure nothing else changes with the addition of the style? I'm not able to reproduce the original issue on main in these stories so I'm assuming these didn't match the required conditions
Member
Author
There was a problem hiding this comment.
correct, it's more about making sure that all instances and uses of it ourselves showcase the correct setup
yihuiliao
previously approved these changes
Jun 23, 2025
# Conflicts: # packages/react-aria-components/docs/Select.mdx
|
Build successful! 🎉 |
yihuiliao
approved these changes
Jun 23, 2025
LFDanLu
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8365
Same resolution and stance as docs: clear up relative position confusion
I built 2 stories based on the Issue codesandbox showing how to fix the issue in RAC and that it was fixed in S2.
RAC: https://reactspectrum.blob.core.windows.net/reactspectrum/9dad0030b38287caaec7c986ea03552af3898ca7/storybook/index.html?path=/story/react-aria-components--select-scroll-bug&providerSwitcher-express=false
S2: https://reactspectrum.blob.core.windows.net/reactspectrum/6643df292ebf895d83c05dbc3f9d5b20785c1654/storybook-s2/index.html?path=/story/picker--select-scroll-bug
There is still a little scrolling in the S2 story due to a margin, not due to the Picker. If the change hadn't been applied, then there would be a massive extra scrolling region.
I removed the stories for the PR because we have a number of these that we don't check again which end up as noise.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: