[RSP-1420] Always show keyboard focus ring when autoFocus is true #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
force-pushed
the
autofocus-ring
branch
from
8853475 to
f72c17a
Compare
devongovett
force-pushed
the
autofocus-ring
branch
from
f72c17a to
1925bc7
Compare
|
Build successful! View the storybook |
dannify
approved these changes
Dec 6, 2019
|
Build successful! View the storybook |
devongovett
pushed a commit
that referenced
this pull request
Jul 25, 2024
* setup storybook docs * add intro page * Remove Picker autodocs * add syntax highlighting to code snippet * add missing autodocs * Remove intro docs for now * remove extra args from Dialog * clean up source formatting Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Rob Snow <rsnow@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that focus is always visible if the
autoFocusprop is set. It adds anautoFocusprop to the<FocusRing>component which is passed through touseFocusVisibleand overrides the global focus visible state. Make sure to pass this prop through if you use FocusRing from now on.