Skip to content

feat(s2): Add triggerRef prop to S2 Popover #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2025
Merged

feat(s2): Add triggerRef prop to S2 Popover #8257

merged 7 commits into from
May 16, 2025

Conversation

devongovett
Copy link
Member

Pulled in #8193 locally so we can get a build, and updated the example slightly.

@rspbot
Copy link

rspbot commented May 16, 2025

@rspbot
Copy link

rspbot commented May 16, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:Popover

 Popover {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   children?: ReactNode | (DialogRenderProps) => ReactNode
   containerPadding?: number = 12
   crossOffset?: number = 0
   hideArrow?: boolean = false
   id?: string
+  isOpen?: boolean
   offset?: number = 8
+  onOpenChange?: (boolean) => void
   placement?: Placement = 'bottom'
   role?: 'dialog' | 'alertdialog' = 'dialog'
   shouldFlip?: boolean = true
   size?: 'S' | 'M' | 'L'
   slot?: string | null
   styles?: StylesProp
+  triggerRef?: RefObject<Element | null>
 }

@devongovett devongovett added this pull request to the merge queue May 16, 2025
@devongovett devongovett mentioned this pull request May 16, 2025
5 tasks
Merged via the queue into main with commit de6fa2a May 16, 2025
30 checks passed
@devongovett devongovett deleted the PLAT-230181 branch May 16, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants