Skip to content

chore: Fix generated code sample for S2 TooltipTrigger docs #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihuiliao merged 3 commits into from
Apr 3, 2025
Merged

chore: Fix generated code sample for S2 TooltipTrigger docs #8000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e1a6db
Fix generated code sample for S2 TooltipTrigger docs
LFDanLu Mar 28, 2025
00d5283
review
LFDanLu Mar 29, 2025
9faa87a
inlining
LFDanLu Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 55 additions & 4 deletions packages/@react-spectrum/s2/stories/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {ActionButton, Button, Provider, Tooltip, TooltipTrigger} from '../src';
import {CombinedTooltip} from '../src/Tooltip';
import Crop from '../s2wf-icons/S2_Icon_Crop_20_N.svg';
import LassoSelect from '../s2wf-icons/S2_Icon_LassoSelect_20_N.svg';
import type {Meta} from '@storybook/react';
import type {Meta, StoryObj} from '@storybook/react';
import {style} from '../style' with {type: 'macro'};

const meta: Meta<typeof CombinedTooltip> = {
Expand Down Expand Up @@ -80,13 +80,32 @@ const ExampleRender = (args: any) => {
);
};

export const Example = {
type Story = StoryObj<typeof CombinedTooltip>;

export const Example: Story = {
render: (args) => <ExampleRender {...args} />,
argTypes: {
isOpen: {
control: 'select',
options: [true, false, undefined]
}
},
parameters: {
docs: {
source: {
transform: () => {
return `
<TooltipTrigger>
<Button aria-label="Crop"><Crop /></Button>
<Tooltip>Crop</Tooltip>
</TooltipTrigger>
<TooltipTrigger>
<ActionButton aria-label="Lasso"><LassoSelect /></ActionButton>
<Tooltip>Lasso</Tooltip>
</TooltipTrigger>`;
}
}
}
}
};

Expand Down Expand Up @@ -126,17 +145,30 @@ const LongLabelRender = (args: any) => {
);
};

export const LongLabel = {
export const LongLabel: Story = {
render: (args) => <LongLabelRender {...args} />,
argTypes: {
isOpen: {
control: 'select',
options: [true, false, undefined]
}
},
parameters: {
docs: {
source: {
transform: () => {
return `
<TooltipTrigger>
<ActionButton aria-label="Lasso"><LassoSelect /></ActionButton>
<Tooltip>Checkbox with very long label so we can see wrapping</Tooltip>
</TooltipTrigger>`;
}
}
}
}
};

export const ColorScheme = {
export const ColorScheme: Story = {
render: (args: any) => (
<Provider colorScheme="dark" background="base" styles={style({padding: 48})}>
<ExampleRender {...args} />
Expand All @@ -147,5 +179,24 @@ export const ColorScheme = {
control: 'select',
options: [true, false, undefined]
}
},
parameters: {
docs: {
source: {
transform: () => {
return `
<Provider colorScheme="dark" background="base" styles={style({padding: 48})}>
<TooltipTrigger>
<Button aria-label="Crop"><Crop /></Button>
<Tooltip>Crop</Tooltip>
</TooltipTrigger>
<TooltipTrigger>
<ActionButton aria-label="Lasso"><LassoSelect /></ActionButton>
<Tooltip>Lasso</Tooltip>
</TooltipTrigger>
</Provider>`;
}
}
}
}
};