Skip to content

fix: exclude isEditable from DateSegment render prop values #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

Persists
Copy link
Contributor

Found in testing. This Prop is Omited from DateSegmentRenderProps, but it was still being passed to the useRenderProps hook.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@Persists Persists closed this Mar 19, 2025
@Persists Persists reopened this Mar 19, 2025
@Persists Persists closed this Mar 19, 2025
@Persists Persists reopened this Mar 19, 2025
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like isEditable was intentionally excluded, so I think this makes sense

not that it really makes a difference, the types would have told someone not to access it regardless

@snowystinger snowystinger added this pull request to the merge queue Mar 20, 2025
Merged via the queue into adobe:main with commit 4b2c6e7 Mar 20, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants