Skip to content

feat: add fetchPriority prop to S2 Image #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: add fetchPriority prop to S2 Image #7706

merged 1 commit into from
Feb 4, 2025

Conversation

chirokas
Copy link
Contributor

@chirokas chirokas commented Feb 3, 2025

In React < 19, we can use fetchpriority (lowercase) to avoid warnings.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao yihuiliao added this pull request to the merge queue Feb 4, 2025
Merged via the queue into adobe:main with commit 9d70953 Feb 4, 2025
30 checks passed
@chirokas chirokas deleted the s2-image-fetchpriority branch February 4, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirokas @snowystinger @yihuiliao