fix: Fix focusing radio, checkbox, and switch on press #7677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues introduced in usePress refactor:
useRadio
/useToggle
include apreventDefault
in the onClick handler on the label. RSP was not affected because there the native input is positioned on top of the label. Removing the preventDefault introduced the second problem...onPointerUp
in case the browser's click event is not fired was triggering in addition to the nativeclick
event. After some spelunking into the WebKit source code, I found that iOS has a 32ms delay on the click event for non-form elements without a specific ARIA role. For radios and toggles, you are tapping on the<label>
element not the actual input so the fast path exception in WebKit does not apply. So our timer of 5ms was firing before the browser's click event was fired, ending up with two clicks. Raising this timeout fixes the issue.