Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule for ts delimiters #747

Merged
merged 12 commits into from
Jul 21, 2020
Merged

Add a rule for ts delimiters #747

merged 12 commits into from
Jul 21, 2020

Conversation

snowystinger
Copy link
Member

I'm doing this because a PR was submitted that changed a bunch of them and we don't want that. Also, once I added the rule, it showed a bunch of places where we had messed it up. So I fixed all of those.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

I'm doing this because a PR was submitted that changed a bunch of them and we don't want that. Also, once I added the rule, it showed a bunch of places where we had messed it up. So I fixed all of those.
@adobe-bot
Copy link

Build successful! 🎉

LFDanLu
LFDanLu previously approved these changes Jul 14, 2020
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang that was a bunch of missing commas and vice versa, thanks for updating the lint rule

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

LFDanLu
LFDanLu previously approved these changes Jul 17, 2020
@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@dannify dannify merged commit c86989a into main Jul 21, 2020
@dannify dannify deleted the lint-ts-delimiter branch July 21, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants