Skip to content

Conversation

mehm8128
Copy link
Contributor

Closes #7207

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

pass href props to span tag which uses useButton
for example this codesandbox implements the span tag button (but this uses the useButton which is before correction)
https://codesandbox.io/p/sandbox/reverent-ives-hl88v2

🧢 Your Project:

@mehm8128 mehm8128 force-pushed the fix-useButton-href-condition branch from cfae219 to f806a19 Compare October 23, 2024 14:07
@reidbarber reidbarber added this pull request to the merge queue Oct 23, 2024
Merged via the queue into adobe:main with commit 09dc3c0 Oct 23, 2024
30 checks passed
@mehm8128 mehm8128 deleted the fix-useButton-href-condition branch October 24, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useButton should not pass href as buttonProps when elementType is other than a
3 participants